From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95080EAF5 for ; Thu, 15 Jun 2023 20:05:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA8D5C433C8; Thu, 15 Jun 2023 20:05:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686859507; bh=CZRKMMFyvWLL7Fxx/I7YyvYMRKdHPJbcAAkIvVyEre0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DvetiO+ccq8E8j7W77N+P4EFu/yQ9EjvGSV7yR2aO2aVRgfgfK6W/jqszhwQzqC+E Hy0TjSSV6yVbsZrKEyOCSO/lUgIXhomOa28NyMgNlLdERlr3tlIVvsDwgDMLRrevc9 QUyCjbkC5qPSzPD0sxhChiKMvV5Xy9sCy+49/YRRpu1Mtm/KKhPc0MsuuqaFeUSTNn si0v5wROeDiIpCJKCxBw1xVa538lf5INBqNiSD+i4k1g/b7sft8yCA4g9WK9Bz+zrH V/hzHjNCdRZ8HO91lpjsnaHbNhvy2jllGCV/HssiNI21iJLjEY8QwggElJGGXo2zJy uhqyToDBuJdpg== Date: Thu, 15 Jun 2023 13:05:06 -0700 From: Jakub Kicinski To: Sarath Babu Naidu Gaddam Cc: , , , , , , , Subject: Re: [PATCH V2] ptp: clockmatrix: Add Defer probe if firmware load fails Message-ID: <20230615130506.3efb333c@kernel.org> In-Reply-To: <20230614051204.1614722-1-sarath.babu.naidu.gaddam@amd.com> References: <20230614051204.1614722-1-sarath.babu.naidu.gaddam@amd.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 14 Jun 2023 10:42:04 +0530 Sarath Babu Naidu Gaddam wrote: > Clock matrix driver can be probed before the rootfs containing > firmware/initialization .bin is available. The current driver > throws a warning and proceeds to execute probe even when firmware > is not ready. Instead, defer probe and wait for the .bin file to > be available. The first-step fix should be to try to get the FW into initramfs. For that driver should specify MODULE_FIRMWARE(), which I don't see here. -- pw-bot: cr