From: Jakub Kicinski <kuba@kernel.org>
To: Jesper Dangaard Brouer <jbrouer@redhat.com>
Cc: Liang Chen <liangchen.linux@gmail.com>,
brouer@redhat.com, hawk@kernel.org, ilias.apalodimas@linaro.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com
Subject: Re: [PATCH net-next] page pool: not return page to alloc cache during pool destruction
Date: Thu, 15 Jun 2023 19:45:24 -0700 [thread overview]
Message-ID: <20230615194524.1201bd0d@kernel.org> (raw)
In-Reply-To: <b28b0e3e-87e4-5a02-c172-2d1424405a5a@redhat.com>
On Thu, 15 Jun 2023 16:00:13 +0200 Jesper Dangaard Brouer wrote:
> Adding a DEBUG_NET_WARN_ON_ONCE will be annoying as I like to run my
> testlab kernels with CONFIG_DEBUG_NET, which will change this extreme
> fash-path slightly (adding some unlikely's affecting code layout to the
> mix).
That's counter-intuitive - the whole point of DEBUG_NET is to have
a place where we can add checks which we don't want in production
builds. If we can't use it on the datapath we should just remove it
completely and have its checks always enabled..
I do feel your pain of having to test code both with debug enabled
and disabled, but we can't have a cookie and eat it too :(
next prev parent reply other threads:[~2023-06-16 2:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 1:36 [PATCH net-next] page pool: not return page to alloc cache during pool destruction Liang Chen
2023-06-15 4:20 ` Jakub Kicinski
2023-06-15 10:49 ` Ilias Apalodimas
2023-06-15 14:00 ` Jesper Dangaard Brouer
2023-06-16 2:45 ` Jakub Kicinski [this message]
2023-06-16 3:07 ` Liang Chen
2023-06-15 9:01 ` Yunsheng Lin
2023-06-15 9:06 ` Yunsheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230615194524.1201bd0d@kernel.org \
--to=kuba@kernel.org \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=jbrouer@redhat.com \
--cc=liangchen.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).