From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BDE6BE4B for ; Mon, 19 Jun 2023 10:48:26 +0000 (UTC) Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B4BD10CF; Mon, 19 Jun 2023 03:48:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1687171705; x=1718707705; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=nIUqjU+9sWui+M1P0a6/KkrhLGUghRBFd77P7yxBipc=; b=JITr5u4/zZ7bIHq99JmoCPXR0K/mdkNHQWTszwOtNOnB1AHziYXYZA2F C18BTT+eUAP1+aOMxbvRfXRfpClw9THx9j5fRT6OObEo4uyS4cH+9zdji k3LPszg2AntnG8vv9FpTxwfWJwTYVdG62Yr7KbVL8lVnxGpxxasHsMgnK TVxSh+p3a/+A1bAPjImA6HgEJAmxBUzBQ7calQGqI3YOJBLU7q6JbRypj 58jLC0SHG63+Uef2sHB5FxSIL5pa6woEiXAXYhvX+eS4jr66d42ksVUMc MX7E9F4QCZjc8KorjIaNzquflD4eEa4kNtlTmK/gCTu2J1YXq3vONY2g7 g==; X-IronPort-AV: E=Sophos;i="6.00,254,1681196400"; d="scan'208";a="220892977" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 19 Jun 2023 03:48:24 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 19 Jun 2023 03:48:14 -0700 Received: from localhost (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2507.21 via Frontend Transport; Mon, 19 Jun 2023 03:48:14 -0700 Date: Mon, 19 Jun 2023 12:48:13 +0200 From: Horatiu Vultur To: "Radu Pirea (OSS)" CC: , , , , , , , , , , Subject: Re: [PATCH net-next v1 12/14] net: phy: nxp-c45-tja11xx: read ext trig ts TJA1120 Message-ID: <20230619104813.tiodielj7faw557s@soft-dev3-1> References: <20230616135323.98215-1-radu-nicolae.pirea@oss.nxp.com> <20230616135323.98215-13-radu-nicolae.pirea@oss.nxp.com> <20230619084941.q6c26zhf4ssnseiu@soft-dev3-1> <1052d020-6866-f1a2-2b59-bec88ff00271@oss.nxp.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <1052d020-6866-f1a2-2b59-bec88ff00271@oss.nxp.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net The 06/19/2023 13:07, Radu Pirea (OSS) wrote: > > On 19.06.2023 11:49, Horatiu Vultur wrote: > > The data->get_extts can't be null. So I don't think you need this check. > > I kinda agree with this because _I wrote the driver and I know what it > does_, but on the other hand don't want to fight with any static analyzer. Yes, but then wouldn't be an issue with the static analyzer tools that can't detect this kind of code? > > > > > -- > > /Horatiu > > -- > Radu P. -- /Horatiu