From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: Piotr Gardocki <piotrx.gardocki@intel.com>,
netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
przemyslaw.kitszel@intel.com, michal.swiatkowski@linux.intel.com,
pmenzel@molgen.mpg.de, maciej.fijalkowski@intel.com,
anthony.l.nguyen@intel.com, simon.horman@corigine.com,
aleksander.lobakin@intel.com
Subject: Re: [PATCH net-next v2 1/3] net: add check for current MAC address in dev_set_mac_address
Date: Tue, 20 Jun 2023 08:59:19 -0700 [thread overview]
Message-ID: <20230620085919.497c3a03@kernel.org> (raw)
In-Reply-To: <17cc8e10-3b54-7bb7-6245-eba11d049034@nvidia.com>
On Tue, 20 Jun 2023 13:42:14 +0300 Gal Pressman wrote:
> > I checked it, you're right. When the addr_assign_type is PERM or RANDOM
> > and user or some driver sets the same MAC address the type doesn't change
> > to NET_ADDR_SET. In my testing I didn't notice issues with that, but I'm
> > sure there are cases I didn't cover. Did you discover any useful cases
> > that broke after this patch or did you just notice it in code?
>
> This behavior change was caught in our regression tests.
Why was the regression test written this way?
I guess we won't flip it back to PERM if user sets a completely
different address temporarily and then back to PERM - so for consistency
going to SET even when the addr doesn't change may be reasonable.
Piotr, you'll need to send a new followup patch on top of net-next.
next prev parent reply other threads:[~2023-06-20 15:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 12:24 [PATCH net-next v2 0/3] optimize procedure of changing MAC address on interface Piotr Gardocki
2023-06-13 12:24 ` [PATCH net-next v2 1/3] net: add check for current MAC address in dev_set_mac_address Piotr Gardocki
2023-06-13 13:10 ` Maciej Fijalkowski
2023-06-13 13:23 ` Paul Menzel
2023-06-13 13:25 ` Fijalkowski, Maciej
2023-06-20 7:16 ` Gal Pressman
2023-06-20 10:29 ` Piotr Gardocki
2023-06-20 10:42 ` Gal Pressman
2023-06-20 15:59 ` Jakub Kicinski [this message]
2023-06-20 16:23 ` Piotr Gardocki
2023-06-20 16:25 ` Gal Pressman
2023-06-13 12:24 ` [PATCH net-next v2 2/3] i40e: remove unnecessary check for old MAC == new MAC Piotr Gardocki
2023-06-13 13:11 ` Maciej Fijalkowski
2023-06-13 12:24 ` [PATCH net-next v2 3/3] ice: " Piotr Gardocki
2023-06-13 13:13 ` Maciej Fijalkowski
2023-06-13 14:02 ` Przemek Kitszel
2023-06-13 15:10 ` [Intel-wired-lan] " Przemek Kitszel
2023-06-13 15:16 ` Piotr Gardocki
2023-06-13 15:24 ` Przemek Kitszel
2023-06-13 15:32 ` Piotr Gardocki
2023-06-13 18:24 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230620085919.497c3a03@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=gal@nvidia.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=maciej.fijalkowski@intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=piotrx.gardocki@intel.com \
--cc=pmenzel@molgen.mpg.de \
--cc=przemyslaw.kitszel@intel.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).