From: Jakub Kicinski <kuba@kernel.org>
To: <Tristram.Ha@microchip.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
<UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH v2 net-next] net: phy: smsc: add WoL support to LAN8740/LAN8742 PHYs
Date: Tue, 20 Jun 2023 11:08:30 -0700 [thread overview]
Message-ID: <20230620110830.7e16eb6f@kernel.org> (raw)
In-Reply-To: <1686788150-2641-1-git-send-email-Tristram.Ha@microchip.com>
On Wed, 14 Jun 2023 17:15:50 -0700 Tristram.Ha@microchip.com wrote:
> Microchip LAN8740/LAN8742 PHYs support basic unicast, broadcast, and
> Magic Packet WoL. They have one pattern filter matching up to 128 bytes
> of frame data, which can be used to implement ARP or multicast WoL.
>
> ARP WoL matches ARP request for IPv4 address of the net device using the
> PHY.
>
> Multicast WoL matches IPv6 Neighbor Solicitation which is sent when
> somebody wants to talk to the net device using IPv6. This
> implementation may not be appropriate and can be changed by users later.
Quick look at lan743x and natsemi seems to indicate that WAKE_ARP means
wake on _any_ arp, not arp directed to the local IPv4 addr.
Could you separate the changes to support other wake types out and post
separately? We can merge that without much controversy. The ARP may
need a discussion. My instinct is that since existing drivers interpret
ARP as any ARP we should add a new type to the uAPI for local ARP.
Sorry for the long review delay.
--
pw-bot: cr
next prev parent reply other threads:[~2023-06-20 18:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 0:15 [PATCH v2 net-next] net: phy: smsc: add WoL support to LAN8740/LAN8742 PHYs Tristram.Ha
2023-06-20 18:08 ` Jakub Kicinski [this message]
2023-06-21 22:58 ` Tristram.Ha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230620110830.7e16eb6f@kernel.org \
--to=kuba@kernel.org \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).