From: Jakub Kicinski <kuba@kernel.org>
To: "Linga, Pavan Kumar" <pavan.kumar.linga@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
<pabeni@redhat.com>, <edumazet@google.com>,
<netdev@vger.kernel.org>, Joshua Hay <joshua.a.hay@intel.com>,
<emil.s.tantilov@intel.com>, <jesse.brandeburg@intel.com>,
<sridhar.samudrala@intel.com>, <shiraz.saleem@intel.com>,
<sindhu.devale@intel.com>, <willemb@google.com>,
<decot@google.com>, <andrew@lunn.ch>, <leon@kernel.org>,
<mst@redhat.com>, <simon.horman@corigine.com>,
<shannon.nelson@amd.com>, <stephen@networkplumber.org>,
Alan Brady <alan.brady@intel.com>,
"Madhu Chittim" <madhu.chittim@intel.com>,
Phani Burra <phani.r.burra@intel.com>,
Shailendra Bhatnagar <shailendra.bhatnagar@intel.com>
Subject: Re: [PATCH net-next v2 03/15] idpf: add controlq init and reset checks
Date: Wed, 21 Jun 2023 12:14:39 -0700 [thread overview]
Message-ID: <20230621121439.382c687f@kernel.org> (raw)
In-Reply-To: <0b6fa05f-d357-2942-d17b-d24d8a5a3321@intel.com>
On Wed, 21 Jun 2023 12:05:54 -0700 Linga, Pavan Kumar wrote:
> >> +void *idpf_alloc_dma_mem(struct idpf_hw *hw, struct idpf_dma_mem *mem, u64 size)
> >> +{
> >> + struct idpf_adapter *adapter = hw->back;
> >> + size_t sz = ALIGN(size, 4096);
> >> +
> >> + mem->va = dma_alloc_coherent(&adapter->pdev->dev, sz,
> >> + &mem->pa, GFP_KERNEL | __GFP_ZERO);
> >
> > DMA API always zeros memory, I thought cocci warns about this
> > Did you run cocci checks?
>
> I ran cocci check using the command "make -j8
> M=drivers/net/ethernet/intel/idpf/ C=1 CHECK="scripts/coccicheck"
> CONFIG_IDPF=m &>>err.log" but didn't see any hits and not sure if this
> is the right command to see the warning. Will fix it anyways.
Ugh, disappointing, looks like people how were chasing these flags
throughout the tree couldn't be bothered to upstream the cocci check.
Or even document it, it seems? :| See 750afb08ca7131 as the initial
commit, FWIW, sorry to misdirect towards coccicheck.
next prev parent reply other threads:[~2023-06-21 19:14 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 17:14 [PATCH net-next v2 00/15][pull request] Introduce Intel IDPF driver Tony Nguyen
2023-06-14 17:14 ` [PATCH net-next v2 01/15] virtchnl: add virtchnl version 2 ops Tony Nguyen
2023-06-14 17:14 ` [PATCH net-next v2 02/15] idpf: add module register and probe functionality Tony Nguyen
2023-06-14 17:14 ` [PATCH net-next v2 03/15] idpf: add controlq init and reset checks Tony Nguyen
2023-06-17 6:42 ` Jakub Kicinski
2023-06-21 19:05 ` Linga, Pavan Kumar
2023-06-21 19:14 ` Jakub Kicinski [this message]
2023-06-21 19:43 ` Simon Horman
2023-06-14 17:14 ` [PATCH net-next v2 04/15] idpf: add core init and interrupt request Tony Nguyen
2023-06-17 6:50 ` Jakub Kicinski
2023-06-21 19:07 ` Linga, Pavan Kumar
2023-06-14 17:14 ` [PATCH net-next v2 05/15] idpf: add create vport and netdev configuration Tony Nguyen
2023-06-14 18:21 ` Stephen Hemminger
2023-06-15 0:12 ` Linga, Pavan Kumar
2023-06-14 17:14 ` [PATCH net-next v2 06/15] idpf: continue expanding init task Tony Nguyen
2023-06-14 17:14 ` [PATCH net-next v2 07/15] idpf: configure resources for TX queues Tony Nguyen
2023-06-14 17:14 ` [PATCH net-next v2 08/15] idpf: configure resources for RX queues Tony Nguyen
2023-06-14 17:14 ` [PATCH net-next v2 09/15] idpf: initialize interrupts and enable vport Tony Nguyen
2023-06-14 17:14 ` [PATCH net-next v2 10/15] idpf: add splitq start_xmit Tony Nguyen
2023-06-14 17:14 ` [PATCH net-next v2 11/15] idpf: add TX splitq napi poll support Tony Nguyen
2023-06-14 17:14 ` [PATCH net-next v2 12/15] idpf: add RX " Tony Nguyen
2023-06-17 6:55 ` Jakub Kicinski
2023-06-21 19:07 ` Linga, Pavan Kumar
2023-06-17 7:01 ` Jakub Kicinski
2023-06-21 19:09 ` Linga, Pavan Kumar
2023-06-21 19:21 ` Jakub Kicinski
2023-06-14 17:14 ` [PATCH net-next v2 13/15] idpf: add singleq start_xmit and napi poll Tony Nguyen
2023-06-14 17:14 ` [PATCH net-next v2 14/15] idpf: add ethtool callbacks Tony Nguyen
2023-06-14 17:14 ` [PATCH net-next v2 15/15] idpf: configure SRIOV and add other ndo_ops Tony Nguyen
-- strict thread matches above, loose matches on Subject: below --
2023-04-11 1:13 [PATCH net-next v2 00/15] Introduce Intel IDPF driver Pavan Kumar Linga
2023-04-11 1:13 ` [PATCH net-next v2 03/15] idpf: add controlq init and reset checks Pavan Kumar Linga
2023-04-11 9:19 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621121439.382c687f@kernel.org \
--to=kuba@kernel.org \
--cc=alan.brady@intel.com \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=decot@google.com \
--cc=edumazet@google.com \
--cc=emil.s.tantilov@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=joshua.a.hay@intel.com \
--cc=leon@kernel.org \
--cc=madhu.chittim@intel.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.kumar.linga@intel.com \
--cc=phani.r.burra@intel.com \
--cc=shailendra.bhatnagar@intel.com \
--cc=shannon.nelson@amd.com \
--cc=shiraz.saleem@intel.com \
--cc=simon.horman@corigine.com \
--cc=sindhu.devale@intel.com \
--cc=sridhar.samudrala@intel.com \
--cc=stephen@networkplumber.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).