From: Jakub Kicinski <kuba@kernel.org>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>,
Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Boris Pismenny <boris.pismenny@gmail.com>
Subject: Re: [PATCH 4/4] net/tls: implement ->read_sock()
Date: Wed, 21 Jun 2023 12:31:32 -0700 [thread overview]
Message-ID: <20230621123132.2e0b487b@kernel.org> (raw)
In-Reply-To: <476d2cd9-ae32-a4e6-4549-52c3863d4049@grimberg.me>
On Wed, 21 Jun 2023 12:49:21 +0300 Sagi Grimberg wrote:
> > Good suggestion.
> > Will be including it in the next round.
>
> Maybe more appropriate helper names would be
> tls_rx_reader_enter / tls_rx_reader_exit.
>
> Whatever Jakub prefers...
I was thinking along the same lines but with __ in front of the names
of the factored out code. Your naming as suggested in the diff is
better.
next prev parent reply other threads:[~2023-06-21 19:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 10:28 [PATCHv5 0/4] net/tls: fixes for NVMe-over-TLS Hannes Reinecke
2023-06-20 10:28 ` [PATCH 1/4] net/tls: handle MSG_EOR for tls_sw TX flow Hannes Reinecke
2023-06-20 10:28 ` [PATCH 2/4] net/tls: handle MSG_EOR for tls_device " Hannes Reinecke
2023-06-20 17:12 ` Sabrina Dubroca
2023-06-21 6:09 ` Hannes Reinecke
2023-06-20 10:28 ` [PATCH 3/4] selftests/net/tls: add test for MSG_EOR Hannes Reinecke
2023-06-20 10:28 ` [PATCH 4/4] net/tls: implement ->read_sock() Hannes Reinecke
2023-06-20 13:21 ` Sagi Grimberg
2023-06-20 17:08 ` Jakub Kicinski
2023-06-21 6:44 ` Hannes Reinecke
2023-06-21 8:39 ` Sagi Grimberg
2023-06-21 9:08 ` Hannes Reinecke
2023-06-21 9:49 ` Sagi Grimberg
2023-06-21 19:31 ` Jakub Kicinski [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-06-14 6:22 [PATCHv4 0/4] net/tls: fixes for NVMe-over-TLS Hannes Reinecke
2023-06-14 6:22 ` [PATCH 4/4] net/tls: implement ->read_sock() Hannes Reinecke
2023-06-17 6:28 ` Jakub Kicinski
2023-06-17 14:08 ` Simon Horman
2023-06-19 8:16 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621123132.2e0b487b@kernel.org \
--to=kuba@kernel.org \
--cc=boris.pismenny@gmail.com \
--cc=edumazet@google.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).