From: Lee Jones <lee@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Christian Marangi <ansuelsmth@gmail.com>,
Pavel Machek <pavel@ucw.cz>,
"David S. Miller" <davem@davemloft.net>,
Yang Li <yang.lee@linux.alibaba.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [net-next PATCH v4 0/3] leds: trigger: netdev: add additional modes
Date: Wed, 21 Jun 2023 15:56:15 +0100 [thread overview]
Message-ID: <20230621145615.GD10378@google.com> (raw)
In-Reply-To: <0462a658-8908-4b8c-9859-8d188f794283@lunn.ch>
On Tue, 20 Jun 2023, Andrew Lunn wrote:
> > > If you do decided to wait, you are going to need to create another
> > > stable branch to pull into netdev. I know it is not a huge overhead,
> > > but it is still work, coordination etc.
> >
> > Can you clarify you last point for me please?
>
> This patchset extends the conditions on which the trigger blinks the
> LED. It adds a couple more values to enum led_trigger_netdev_modes in
> include/linux/leds.h. Once it gets merged, i will have a followup
> patch extending the Marvell PHY driver to make us of them. It will
> need these additional enum values. I also expect other PHY drivers to
> gain support for them. Probably the dp83867.c driver since Alexander
> Stein already has a patch merged adding support for what the current
> API supports.
>
> If we merge this patchset now via netdev, -rc1 should have everything
> we need for this continuing development work. If we wait to merge
> these patches until -rc1, only the LED tree has the needed patches, so
> these network drivers will need a stable branch we can pull into
> netdev.
>
> Both ways work, we can do either. But it is probably easier for
> everybody to merge now via netdev.
Got it, thanks.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-06-21 14:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-17 11:53 [net-next PATCH v4 0/3] leds: trigger: netdev: add additional modes Christian Marangi
2023-06-17 11:53 ` [net-next PATCH v4 1/3] leds: trigger: netdev: add additional specific link speed mode Christian Marangi
2023-06-17 11:53 ` [net-next PATCH v4 2/3] leds: trigger: netdev: add additional specific link duplex mode Christian Marangi
2023-06-18 20:10 ` Andrew Lunn
2023-06-17 11:53 ` [net-next PATCH v4 3/3] leds: trigger: netdev: expose hw_control status via sysfs Christian Marangi
2023-06-18 20:15 ` Andrew Lunn
2023-06-19 10:40 ` [net-next PATCH v4 0/3] leds: trigger: netdev: add additional modes Lee Jones
2023-06-19 13:34 ` Andrew Lunn
2023-06-20 10:26 ` Lee Jones
2023-06-20 13:59 ` Andrew Lunn
2023-06-21 14:56 ` Lee Jones [this message]
2023-06-19 20:27 ` Simon Horman
2023-06-19 20:48 ` Christian Marangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621145615.GD10378@google.com \
--to=lee@kernel.org \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).