From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev <netdev@vger.kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <rmk+kernel@armlinux.org.uk>,
Simon Horman <simon.horman@corigine.com>,
Christian Marangi <ansuelsmth@gmail.com>
Subject: Re: [PATCH net-next v1 2/3] net: phy: phy_device: Call into the PHY driver to set LED offload
Date: Wed, 21 Jun 2023 15:24:15 -0700 [thread overview]
Message-ID: <20230621152415.0bf552f3@kernel.org> (raw)
In-Reply-To: <20230619215703.4038619-3-andrew@lunn.ch>
On Mon, 19 Jun 2023 23:57:02 +0200 Andrew Lunn wrote:
> + /**
> + * Can the HW support the given rules. Return 0 if yes,
> + * -EOPNOTSUPP if not, or an error code.
> + */
> + int (*led_hw_is_supported)(struct phy_device *dev, u8 index,
> + unsigned long rules);
> + /**
> + * Set the HW to control the LED as described by rules.
> + */
> + int (*led_hw_control_set)(struct phy_device *dev, u8 index,
> + unsigned long rules);
> + /**
> + * Get the rules used to describe how the HW is currently
> + * configure.
> + */
> + int (*led_hw_control_get)(struct phy_device *dev, u8 index,
> + unsigned long *rules);
Why not include @led_hw_control_get in the kernel doc?
IIUC the problem is that the value doesn't get rendered when building
documentation correctly, but that should get resolved sooner or later.
OTOH what this patch adds is not valid kdoc at all, and it will never
be valid, right?
next prev parent reply other threads:[~2023-06-21 22:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 21:57 [PATCH net-next v1 0/3] Support offload LED blinking to PHY Andrew Lunn
2023-06-19 21:57 ` [PATCH net-next v1 1/3] led: trig: netdev: Fix requesting offload device Andrew Lunn
2023-06-21 13:37 ` Simon Horman
2023-06-21 15:19 ` Andrew Lunn
2023-06-21 15:34 ` Simon Horman
2023-06-19 21:57 ` [PATCH net-next v1 2/3] net: phy: phy_device: Call into the PHY driver to set LED offload Andrew Lunn
2023-06-21 13:39 ` Simon Horman
2023-06-21 22:24 ` Jakub Kicinski [this message]
2023-06-21 22:28 ` Jakub Kicinski
2023-06-19 21:57 ` [PATCH net-next v1 3/3] net: phy: marvell: Add support for offloading LED blinking Andrew Lunn
2023-06-21 13:45 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621152415.0bf552f3@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).