From: Jakub Kicinski <kuba@kernel.org>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: netdev@vger.kernel.org, mengyuanlou@net-swift.com
Subject: Re: [PATCH net] net: txgbe: change hw reset mode
Date: Thu, 22 Jun 2023 19:21:58 -0700 [thread overview]
Message-ID: <20230622192158.50da604e@kernel.org> (raw)
In-Reply-To: <20230621090645.125466-1-jiawenwu@trustnetic.com>
On Wed, 21 Jun 2023 17:06:45 +0800 Jiawen Wu wrote:
> The old way to do hardware reset is sending reset command to firmware.
> In order to adapt to the new firmware, driver directly write register
> of LAN reset instead of the old way.
Which versions of the FW use one method vs the other? Why is it okay
to change the driver for new FW, are there no devices running old FW
in the wild? Or the new method is safe for both?
We need more information, we had a number of reports recently about
drivers breaking backwards compatibility and causing regressions for
users.
> And remove the redundant functions
> wx_reset_hostif() and wx_calculate_checksum().
You don't have to say that, it's a natural part of the change.
--
pw-bot: cr
next prev parent reply other threads:[~2023-06-23 2:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 9:06 [PATCH net] net: txgbe: change hw reset mode Jiawen Wu
2023-06-23 2:21 ` Jakub Kicinski [this message]
2023-06-25 8:31 ` mengyuanlou
2023-06-25 15:40 ` Andrew Lunn
2023-06-26 1:56 ` mengyuanlou
2023-06-26 17:24 ` Jakub Kicinski
2023-06-27 2:18 ` mengyuanlou
2023-06-27 3:28 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230622192158.50da604e@kernel.org \
--to=kuba@kernel.org \
--cc=jiawenwu@trustnetic.com \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).