From: Jakub Kicinski <kuba@kernel.org>
To: Mengyuan Lou <mengyuanlou@net-swift.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: ngbe: add Wake on Lan support
Date: Thu, 22 Jun 2023 19:25:45 -0700 [thread overview]
Message-ID: <20230622192528.7bef1fa3@kicinski-fedora-PC1C0HJN> (raw)
In-Reply-To: <D021CF8344C66466+20230621094744.74032-1-mengyuanlou@net-swift.com>
On Wed, 21 Jun 2023 17:47:44 +0800 Mengyuan Lou wrote:
> + if (wol->wolopts & WAKE_MAGIC)
> + return -EOPNOTSUPP;
> +
> + wx->wol = 0;
> + if (wol->wolopts & WAKE_MAGIC)
Maybe my eyes deceive me but it looks like you're rejecting all
configurations with WAKE_MAGIC set and then only supporting WAKE_MAGIC.
Did you mean to negate the first check?
How did you test this change?
--
pw-bot: cr
next prev parent reply other threads:[~2023-06-23 2:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 9:47 [PATCH net-next v2] net: ngbe: add Wake on Lan support Mengyuan Lou
2023-06-23 2:25 ` Jakub Kicinski [this message]
2023-06-25 7:39 ` mengyuanlou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230622192528.7bef1fa3@kicinski-fedora-PC1C0HJN \
--to=kuba@kernel.org \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox