From: Jakub Kicinski <kuba@kernel.org>
To: Nick Child <nnac123@linux.ibm.com>
Cc: netdev@vger.kernel.org, haren@linux.ibm.com, ricklind@us.ibm.com
Subject: Re: [PATCH net] ibmvnic: Do not reset dql stats on NON_FATAL err
Date: Sat, 24 Jun 2023 15:19:11 -0700 [thread overview]
Message-ID: <20230624151911.7442620c@kernel.org> (raw)
In-Reply-To: <20230622190332.29223-1-nnac123@linux.ibm.com>
On Thu, 22 Jun 2023 14:03:32 -0500 Nick Child wrote:
> + if (adapter->reset_reason == VNIC_RESET_NON_FATAL)
> + clear_bit(__QUEUE_STATE_STACK_XOFF,
> + &netdev_get_tx_queue(netdev, i)->state);
Why are you trying to clear this bit?
If the completions will still come the bit will be cleared (or not)
during completion handling (netdev_tx_completed_queue() et al.)
Drivers shouldn't be poking into queue state bits directly.
--
pw-bot: cr
next prev parent reply other threads:[~2023-06-24 22:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 19:03 [PATCH net] ibmvnic: Do not reset dql stats on NON_FATAL err Nick Child
2023-06-23 7:52 ` Simon Horman
2023-06-23 12:41 ` Simon Horman
2023-06-23 12:24 ` Rick Lindsley
2023-06-24 22:19 ` Jakub Kicinski [this message]
2023-06-26 15:45 ` Nick Child
2023-06-26 17:33 ` Jakub Kicinski
2023-06-26 19:23 ` Nick Child
2023-06-26 19:06 ` Rick Lindsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230624151911.7442620c@kernel.org \
--to=kuba@kernel.org \
--cc=haren@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nnac123@linux.ibm.com \
--cc=ricklind@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).