From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45EF8DDDD for ; Sat, 24 Jun 2023 22:19:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 868DCC433C0; Sat, 24 Jun 2023 22:19:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687645152; bh=idJ66CRxT3yfJvKA9u94RA70y7BMoYCiaLo9F/vPj1w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NQoU9/Cvaljws7IscaBPy5n1X320AYW1Bv27puvgqSJkdj2QRxaXsatElti+TtcDg npesna2s1JSPGMDbAx3efWbO6G2H3iOuUcdoWZxCybiIYegR/IV6PIjkZo4ggNz8ya ddZrS6cy1uKSqWy7scWIxp7cAL2GT30isP8g+QnSzahHvytMmNal8m45JGvrNoj8Gl 6Ma+iqQSuifHljv/MNCgKdrg2R9cVltuBN0hl1P+eOqGcrx1U0sjyyK7SgeqsNqbXa a/OXhUWJwFLnvhyEmyLTQNnQziwkdOeKQjqhpkqHBAtP13e4VyftTZnWyc1fLNsS/1 TuplP+/J19Ohg== Date: Sat, 24 Jun 2023 15:19:11 -0700 From: Jakub Kicinski To: Nick Child Cc: netdev@vger.kernel.org, haren@linux.ibm.com, ricklind@us.ibm.com Subject: Re: [PATCH net] ibmvnic: Do not reset dql stats on NON_FATAL err Message-ID: <20230624151911.7442620c@kernel.org> In-Reply-To: <20230622190332.29223-1-nnac123@linux.ibm.com> References: <20230622190332.29223-1-nnac123@linux.ibm.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 22 Jun 2023 14:03:32 -0500 Nick Child wrote: > + if (adapter->reset_reason == VNIC_RESET_NON_FATAL) > + clear_bit(__QUEUE_STATE_STACK_XOFF, > + &netdev_get_tx_queue(netdev, i)->state); Why are you trying to clear this bit? If the completions will still come the bit will be cleared (or not) during completion handling (netdev_tx_completed_queue() et al.) Drivers shouldn't be poking into queue state bits directly. -- pw-bot: cr