From: "Michael S. Tsirkin" <mst@redhat.com>
To: Heng Qi <hengqi@linux.alibaba.com>
Cc: Simon Horman <simon.horman@corigine.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
Jason Wang <jasowang@redhat.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>
Subject: Re: [PATCH net-next v2 1/3] virtio-net: reprobe csum related fields for skb passed by XDP
Date: Sun, 25 Jun 2023 17:53:54 -0400 [thread overview]
Message-ID: <20230625175337-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <45bda8e7-8d4a-c7c9-1fe2-af6926329ef7@linux.alibaba.com>
On Sun, Jun 25, 2023 at 10:17:15AM +0800, Heng Qi wrote:
>
>
> 在 2023/6/25 上午3:28, Simon Horman 写道:
> > On Sat, Jun 24, 2023 at 08:26:02PM +0800, Heng Qi wrote:
> >
> > ...
> >
> > > +static int virtnet_set_csum_after_xdp(struct virtnet_info *vi,
> > > + struct sk_buff *skb,
> > > + __u8 flags)
> > Hi Heng Qi,
> >
> > Unfortunately this appears to break an x86_64 allmodconfig build
> > with GCC 12.3.0:
> >
> > drivers/net/virtio_net.c:1671:12: error: 'virtnet_set_csum_after_xdp' defined but not used [-Werror=unused-function]
>
> I admit that this is a patch set, you can cherry-pick patches [1/3] and
> [2/3] together
> to make it compile without 'defined but not used' warning. If people don't
> want to
> separate [1/3] and [2/3], I can squash them into one. :)
>
> Thanks.
the answer is yes, do not break the build.
> > 1671 | static int virtnet_set_csum_after_xdp(struct virtnet_info *vi,
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > --
> > pw-bot: changes-requested
next prev parent reply other threads:[~2023-06-25 21:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-24 12:26 [PATCH net-next v2 0/3] virtio-net: avoid conflicts between XDP and GUEST_CSUM Heng Qi
2023-06-24 12:26 ` [PATCH net-next v2 1/3] virtio-net: reprobe csum related fields for skb passed by XDP Heng Qi
2023-06-24 19:28 ` Simon Horman
2023-06-25 2:17 ` Heng Qi
2023-06-25 21:53 ` Michael S. Tsirkin [this message]
2023-06-25 6:44 ` Jason Wang
2023-06-25 7:27 ` Heng Qi
2023-06-26 2:09 ` Jason Wang
2023-06-26 3:34 ` Heng Qi
2023-06-24 12:26 ` [PATCH net-next v2 2/3] virtio-net: support coexistence of XDP and GUEST_CSUM Heng Qi
2023-06-24 12:26 ` [PATCH net-next v2 3/3] virtio-net: remove GUEST_CSUM check for XDP Heng Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230625175337-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=hengqi@linux.alibaba.com \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).