From: Jakub Kicinski <kuba@kernel.org>
To: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
netdev@vger.kernel.org,
Wojciech Drewek <wojciech.drewek@intel.com>,
jiri@resnulli.us, ivecera@redhat.com, simon.horman@corigine.com,
Sujai Buvaneswaran <sujai.buvaneswaran@intel.com>,
Vlad Buslov <vladbu@nvidia.com>
Subject: Re: [PATCH net-next 06/12] ice: Implement basic eswitch bridge setup
Date: Mon, 26 Jun 2023 10:35:42 -0700 [thread overview]
Message-ID: <20230626103542.68800299@kernel.org> (raw)
In-Reply-To: <ZJmgB9fUPE+nfmoh@localhost.localdomain>
On Mon, 26 Jun 2023 16:26:15 +0200 Michal Swiatkowski wrote:
> We found out that adding VF and corresponding port representor to the
> bridge cause loop in the bridge. Packets are looping through the bridge.
> I know that it isn't valid configuration, howevere, it can happen and
> after that the server is quite unstable.
>
> Does mellanox validate the port for this scenario? Or we should assume
> that user will add port wisely? I was looking at your code, but didn't
> find that. You are using NETDEV_PRECHANGEUPPER, do you think we should
> validate if user is trying to add VF when his PR is currently added?
Can you try to plug two ends of a veth into a bridge and see if the
same thing happens? My instinct is that this is a classic bridge
problem and the answer is STP.
next prev parent reply other threads:[~2023-06-26 17:35 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 17:44 [PATCH net-next 00/12][pull request] ice: switchdev bridge offload Tony Nguyen
2023-06-20 17:44 ` [PATCH net-next 01/12] ice: Skip adv rules removal upon switchdev release Tony Nguyen
2023-06-20 17:44 ` [PATCH net-next 02/12] ice: Prohibit rx mode change in switchdev mode Tony Nguyen
2023-06-20 17:44 ` [PATCH net-next 03/12] ice: Don't tx before switchdev is fully configured Tony Nguyen
2023-06-20 17:44 ` [PATCH net-next 04/12] ice: Disable vlan pruning for uplink VSI Tony Nguyen
2023-06-20 17:44 ` [PATCH net-next 05/12] ice: Unset src prune on " Tony Nguyen
2023-06-20 17:44 ` [PATCH net-next 06/12] ice: Implement basic eswitch bridge setup Tony Nguyen
2023-06-26 14:26 ` Michal Swiatkowski
2023-06-26 14:31 ` Vlad Buslov
2023-06-27 6:46 ` Michal Swiatkowski
2023-06-26 17:35 ` Jakub Kicinski [this message]
2023-06-27 6:41 ` Michal Swiatkowski
2023-06-20 17:44 ` [PATCH net-next 07/12] ice: Switchdev FDB events support Tony Nguyen
2023-06-21 13:55 ` Simon Horman
2023-06-22 11:53 ` Vlad Buslov
2023-06-22 12:55 ` Drewek, Wojciech
2023-06-20 17:44 ` [PATCH net-next 08/12] ice: Add guard rule when creating FDB in switchdev Tony Nguyen
2023-06-20 17:44 ` [PATCH net-next 09/12] ice: Add VLAN FDB support in switchdev mode Tony Nguyen
2023-06-21 13:59 ` Simon Horman
2023-06-22 12:03 ` Vlad Buslov
2023-06-22 13:06 ` Drewek, Wojciech
2023-06-20 17:44 ` [PATCH net-next 10/12] ice: implement bridge port vlan Tony Nguyen
2023-06-22 12:07 ` Vlad Buslov
2023-06-22 17:07 ` Drewek, Wojciech
2023-06-20 17:44 ` [PATCH net-next 11/12] ice: implement static version of aging Tony Nguyen
2023-06-20 17:44 ` [PATCH net-next 12/12] ice: add tracepoints for the switchdev bridge Tony Nguyen
2023-06-20 18:12 ` [PATCH net-next 00/12][pull request] ice: switchdev bridge offload Jakub Kicinski
2023-06-21 19:25 ` Vlad Buslov
2023-06-22 17:13 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230626103542.68800299@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
--cc=sujai.buvaneswaran@intel.com \
--cc=vladbu@nvidia.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).