From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47E7ED505 for ; Mon, 26 Jun 2023 19:58:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2CE4C433C8; Mon, 26 Jun 2023 19:58:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687809500; bh=ldB+MatWlVsNCLZ0mR+Yj//TS0gmW2dKp23REUfd6MU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=u697IQCtWc7mPfP5qNsMU2uWqPdgmV1hJ9wSJ61mq7qWHcO0fSuOP1QJw+GQeHeJH yz3fVEY9D+3Y2y0raE7vu687ZMFBltGJd3Hbyz5/t59QlAG5BYc6OUe21J6p2bNMVf OFGKjOGg70AKDzOnVr+EfgC/iuPcBNc0vy+l4Bv2s2efBnkJHfTS8DYof2UJupzYOc FS4iuCYuKTQ+vdUlmXxHzPYvwMhsLdhSlxZx2f6bZWgp4nNp2LWcKxhCIuuJAQb1oC e1bDUJvq8rLTipdMQC6SN1Xtd48ku1uo9jnnBTMDyzo9BLxP76wRPO06DnbgNaGR/F w1PG4+jOG5OGw== Date: Mon, 26 Jun 2023 12:58:18 -0700 From: Jakub Kicinski To: Abel Wu Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , David Ahern , Yosry Ahmed , "Matthew Wilcox (Oracle)" , Yu Zhao , Kuniyuki Iwashima , Alexei Starovoitov , Martin KaFai Lau , Alexander Mikhalitsyn , Breno Leitao , David Howells , Jason Xing , Xin Long , Michal Hocko , linux-kernel@vger.kernel.org (open list), netdev@vger.kernel.org (open list:NETWORKING [GENERAL]), cgroups@vger.kernel.org (open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)), linux-mm@kvack.org (open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)) Subject: Re: [PATCH net-next 1/2] net-memcg: Scopify the indicators of sockmem pressure Message-ID: <20230626125818.74193aea@kernel.org> In-Reply-To: <20230625142820.47185-1-wuyun.abel@bytedance.com> References: <20230625142820.47185-1-wuyun.abel@bytedance.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 25 Jun 2023 22:28:10 +0800 Abel Wu wrote: > Now there are two indicators of socket memory pressure sit inside > struct mem_cgroup, socket_pressure and tcpmem_pressure. > > When in legacy mode aka. cgroupv1, the socket memory is charged > into a separate counter memcg->tcpmem rather than ->memory, so > the reclaim pressure of the memcg has nothing to do with socket's > pressure at all. While for default mode, the ->tcpmem is simply > not used. > > So {socket,tcpmem}_pressure are only used in default/legacy mode > respectively. This patch fixes the pieces of code that make mixed > use of both. The merge window for 6.5 has now started, let's defer this until 6.6. Please repost in ~2 weeks. -- pw-bot: defer