From: Jakub Kicinski <kuba@kernel.org>
To: Mengyuan Lou <mengyuanlou@net-swift.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3] net: ngbe: add Wake on Lan support
Date: Mon, 26 Jun 2023 13:17:57 -0700 [thread overview]
Message-ID: <20230626131757.3a7b04c0@kernel.org> (raw)
In-Reply-To: <934157CCB15D2775+20230626083708.47930-1-mengyuanlou@net-swift.com>
On Mon, 26 Jun 2023 16:37:08 +0800 Mengyuan Lou wrote:
> + if (!wx->wol_hw_supported)
> + return -EOPNOTSUPP;
> + if (!(wol->wolopts & WAKE_MAGIC) &&
> + wol->wolopts != 0)
> + return -EOPNOTSUPP;
AFAIK core (by which I mean net/ethtool/* code) already checks that
bits outside of ->supported are not set in wolopts.
Please post v4 after the merge window (in 2 weeks)
--
pw-bot: cr
prev parent reply other threads:[~2023-06-26 20:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 8:37 [PATCH net-next v3] net: ngbe: add Wake on Lan support Mengyuan Lou
2023-06-26 20:17 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230626131757.3a7b04c0@kernel.org \
--to=kuba@kernel.org \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).