From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BAD414A80 for ; Mon, 26 Jun 2023 20:17:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8163C433C8; Mon, 26 Jun 2023 20:17:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687810678; bh=9T+7daHgx1xtss02IAOpdNskFIch4WssAJyVD94wQPk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fNjo0SOxC5EgergGPGlU5IVCl6HU50kzS0hd85d7QosQmNfvCgkojzodGslc/N6tH 5TLMEr3y8aK3fB/4y99aGdDFUR7PNBplWlubSl8zQZ07D4NtwzQ2+1Dyw10pzKDqrl K1/N/lITfLOX5IUVWcCERHlralJ5M3SXmjeu7U55OQpPfh/3VxciBnJRiuGTgYfZpT KL9W5I+PYn1fFI5zpZMKT5Mbs/0nNdVoGuU3GLK+YzXzy3SECy6eTGRWxMGWAkwN6S 5IKws6V5seP1aylnJZV27J20YxjMZCr1f+XYUabwFvSMSFYPzPAOf99djTupqKqBpW KtlewcdP4hCaA== Date: Mon, 26 Jun 2023 13:17:57 -0700 From: Jakub Kicinski To: Mengyuan Lou Cc: netdev@vger.kernel.org Subject: Re: [PATCH net-next v3] net: ngbe: add Wake on Lan support Message-ID: <20230626131757.3a7b04c0@kernel.org> In-Reply-To: <934157CCB15D2775+20230626083708.47930-1-mengyuanlou@net-swift.com> References: <934157CCB15D2775+20230626083708.47930-1-mengyuanlou@net-swift.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 26 Jun 2023 16:37:08 +0800 Mengyuan Lou wrote: > + if (!wx->wol_hw_supported) > + return -EOPNOTSUPP; > + if (!(wol->wolopts & WAKE_MAGIC) && > + wol->wolopts != 0) > + return -EOPNOTSUPP; AFAIK core (by which I mean net/ethtool/* code) already checks that bits outside of ->supported are not set in wolopts. Please post v4 after the merge window (in 2 weeks) -- pw-bot: cr