From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D99C17FEF for ; Mon, 26 Jun 2023 21:51:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F06A2C433C9; Mon, 26 Jun 2023 21:51:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687816292; bh=XzLyUG9IOF2FmNlCE9hkjcb5E8FRkyeQNTklQWGEU1M=; h=From:To:Cc:Subject:Date:From; b=egIUODX7uD4ep4uGrUhZDWFLXhZNWu54R9SAPk7CnViFWjWef5GjmGQL5ovaRLfza WN8OGAvf09o4LxxqNfyJHa49JD5WvuAOSkOGBYvEmsMjN0Xvw/QThiXE6UcnB5tpbu k9qYqqcOiA6elJfVts6/vge+X+Z1N8IFbzFZ5ipBWXhfpF2WyLXVQ0KjMTBPqlSfOo zVthcyQUa3ZykoxFQYS1RH/Z0oH29kEDuvlZ4VJRpH7kJ36k8rA5Wlg4tI++eXsIxP aGV3gcb0k3RwOmj4EKoGqjqgs9mEcN0HfBEgLfOLCvZIx3JxP/UamNKFvGpyX2Wx3/ OoHuJsroLEOFw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dmitry Mastykin , Paul Moore , "David S . Miller" , Sasha Levin , edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-security-module@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 1/5] netlabel: fix shift wrapping bug in netlbl_catmap_setlong() Date: Mon, 26 Jun 2023 17:51:26 -0400 Message-Id: <20230626215130.179740-1-sashal@kernel.org> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.14.319 Content-Transfer-Encoding: 8bit From: Dmitry Mastykin [ Upstream commit b403643d154d15176b060b82f7fc605210033edd ] There is a shift wrapping bug in this code on 32-bit architectures. NETLBL_CATMAP_MAPTYPE is u64, bitmap is unsigned long. Every second 32-bit word of catmap becomes corrupted. Signed-off-by: Dmitry Mastykin Acked-by: Paul Moore Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/netlabel/netlabel_kapi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/netlabel/netlabel_kapi.c b/net/netlabel/netlabel_kapi.c index 15fe2120b3109..14c3d640f94b9 100644 --- a/net/netlabel/netlabel_kapi.c +++ b/net/netlabel/netlabel_kapi.c @@ -871,7 +871,8 @@ int netlbl_catmap_setlong(struct netlbl_lsm_catmap **catmap, offset -= iter->startbit; idx = offset / NETLBL_CATMAP_MAPSIZE; - iter->bitmap[idx] |= bitmap << (offset % NETLBL_CATMAP_MAPSIZE); + iter->bitmap[idx] |= (NETLBL_CATMAP_MAPTYPE)bitmap + << (offset % NETLBL_CATMAP_MAPSIZE); return 0; } -- 2.39.2