From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D2A61991B for ; Tue, 27 Jun 2023 15:24:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 379BBC433C8; Tue, 27 Jun 2023 15:24:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687879470; bh=WAVMj4k643XkD8zEGHR9X/xsm5cOk5NFtasKqScWN0k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mOwv9Z+FqIBr9aDu2uX1W+InNnC2XilmtmuBOUJPST7mjYxMIpqB9ZBEG8Fl5z5vQ GqL6qO+PNLIcw67OrgfxF1KEF6eU8OhvyvGXXP/+e0qgrug0hzFqKroqzm+vpD+iyZ ioVlK/fFN46wTdCTnvn+y/AgdqZK4JoF076r2NM7dfrDR0wBUth6TvSBlCjpsnkdpV 0v++0IWLAWETbySsOdqt47/xxlrN9kRkOz0o8OEXugcqOui1PXS9OVVkp+E52c4fvW s7avGWFV/aNcuUNPw+9Wyz6LETQ4Nbu83cCT4w1G3+DeApeppgVG8rWWXELP9oImvH 79ZvMo67BwyAg== Date: Tue, 27 Jun 2023 08:24:29 -0700 From: Jakub Kicinski To: Jiri Pirko Cc: Saeed Mahameed , Saeed Mahameed , "David S. Miller" , Paolo Abeni , Eric Dumazet , netdev@vger.kernel.org, Tariq Toukan , Shay Drory , Moshe Shemesh Subject: Re: [net-next 14/15] net/mlx5: Light probe local SFs Message-ID: <20230627082429.36100040@kernel.org> In-Reply-To: References: <20230615093701.20d0ad1b@kernel.org> <20230615123325.421ec9aa@kernel.org> <20230622093523.18993f44@kernel.org> <20230623082108.7a4973cc@kernel.org> <20230624134703.10ec915f@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 27 Jun 2023 12:12:10 +0200 Jiri Pirko wrote: > $ sudo devlink port add pci/0000:08:00.0 flavour pcisf pfnum 0 sfnum 103 > pci/0000:08:00.0/32770: type eth netdev eth10 flavour pcisf controller 0 pfnum 0 sfnum 103 splittable false > function: > hw_addr 00:00:00:00:00:00 state inactive opstate detached > > $ sudo devlink port function set pci/0000:08:00.0/32770 hw_addr AA:22:33:44:55:66 uuid SOMETHINGREALLYUNIQUE Why does the user have to set the uuid? I was expecting it'd pop up on the port automatically, generated by the kernel, as a read-only attribute.