From: Stephen Hemminger <stephen@networkplumber.org>
To: Bjarni Ingi Gislason <bjarniig@simnet.is>
Cc: netdev@vger.kernel.org
Subject: Re: tc.8: some remarks and a patch for the manual
Date: Tue, 27 Jun 2023 10:38:49 -0700 [thread overview]
Message-ID: <20230627103849.7bce7b54@hermes.local> (raw)
In-Reply-To: <168764283038.2838.1146738227989939935.reportbug@kassi.invalid.is.lan>
On Sat, 24 Jun 2023 21:43:21 +0000
Bjarni Ingi Gislason <bjarniig@simnet.is> wrote:
> Package: iproute2
> Version: 6.3.0
> Severity: minor
> Tags: patch
>
> Dear Maintainer,
>
> here are some notes and a patch.
>
> The difference between the formatted outputs can be seen with:
>
> nroff -man <file1> > <out1>
> nroff -man <file2> > <out2>
> diff -u <out1> <out2>
>
> and for groff, using
>
> "groff -man -Z" instead of "nroff -man"
Overall this looks fine but:
1. Make the commit message more succinct and clearer, don't need to write a letter.
2. Lines with starting with # get ignored by git when committing
3. Missing Signed-Off-by which is required for all iproute2 patches.
Running checkpatch on this patch will show these things.
next prev parent reply other threads:[~2023-06-27 17:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-24 21:43 tc.8: some remarks and a patch for the manual Bjarni Ingi Gislason
2023-06-27 17:38 ` Stephen Hemminger [this message]
2023-06-28 0:44 ` Bjarni Ingi Gislason
2023-06-28 18:22 ` David Ahern
2023-06-29 16:50 ` Bjarni Ingi Gislason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230627103849.7bce7b54@hermes.local \
--to=stephen@networkplumber.org \
--cc=bjarniig@simnet.is \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).