From: Jakub Kicinski <kuba@kernel.org>
To: Shannon Nelson <shannon.nelson@amd.com>
Cc: "Keller, Jacob E" <jacob.e.keller@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"brett.creeley@amd.com" <brett.creeley@amd.com>,
"drivers@pensando.io" <drivers@pensando.io>,
"nitya.sunkad@amd.com" <nitya.sunkad@amd.com>
Subject: Re: [PATCH net] ionic: remove WARN_ON to prevent panic_on_warn
Date: Wed, 28 Jun 2023 14:06:12 -0700 [thread overview]
Message-ID: <20230628140612.4736ed58@kernel.org> (raw)
In-Reply-To: <1b33f325-c104-8b0c-099f-f2d2e98fed66@amd.com>
On Wed, 28 Jun 2023 11:26:18 -0700 Shannon Nelson wrote:
> > This message could potentially use a bit more explanation since it
> > doesn't look like you removed all the WARN_ONs in the driver, and
> > it might help to explain why this particular WARN_ON was
> > problematic. I don't think that would be worth a re-roll on its own
> > though.
>
> There has been recent mention of not using WARNxxx macros because so
> many folks have been setting panic_on_warn [1]. This is intended to
> help mitigate the possibility of unnecessarily killing a machine when
> we can adjust and continue.
> [1]:
> https://lore.kernel.org/netdev/2023060820-atom-doorstep-9442@gregkh/
>
> I believe the only other WARNxxx in this driver is a WARN_ON_ONCE in
> ionic_regs.h which can be addressed in a separate patch.
>
> Neither of these are ever expected to be hit, but also neither should
> ever kill a machine.
An explanation that this warning may in fact be hit and how in
the commit message would be good.
next parent reply other threads:[~2023-06-28 21:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230628170050.21290-1-shannon.nelson@amd.com>
[not found] ` <CO1PR11MB50899225D4BCFFA435A96FB6D624A@CO1PR11MB5089.namprd11.prod.outlook.com>
[not found] ` <1b33f325-c104-8b0c-099f-f2d2e98fed66@amd.com>
2023-06-28 21:06 ` Jakub Kicinski [this message]
2023-06-29 17:25 ` [PATCH net] ionic: remove WARN_ON to prevent panic_on_warn Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230628140612.4736ed58@kernel.org \
--to=kuba@kernel.org \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=drivers@pensando.io \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nitya.sunkad@amd.com \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).