From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95EB7134AF for ; Thu, 29 Jun 2023 16:11:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96951C433C0; Thu, 29 Jun 2023 16:11:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688055091; bh=poaFO3/bPh14xOgLxoo80j/K9Q/PKlqqhRQVP/H2PzY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qux7W8jRi3usYygYWoKQ80BcrBb8GJWqLvuGuwL8lbBwBavexsXOYZo/YD8NXuGDQ d1242atZe6+maXcqWu2UAnmYyd7J7+MA4DN1eT1MDIHRkyEzElW6VSEb3knMaRxKVW XEppM1gEwcAG3KvCTuYd1XN0lhyMaDdVi+bDG9Xza9K/Yxe3evXQMuZbe1q8stHxpw jFl+XugO0YcGPCK7GH6CqDyUXfsresz9YrZfrbnLfuigc4HXzyiy3N4mFJYza82u5e UronuKaEFZqz/r813jLP8q4qjeNA/rQDcvX4hMDW6iDW1hqjlUjnGMF6i94Uc3bgst bhOgvbvlqGHhA== Date: Thu, 29 Jun 2023 09:11:29 -0700 From: Jakub Kicinski To: longli@linuxonhyperv.com Cc: Paolo Abeni , Jason Gunthorpe , Leon Romanovsky , Ajay Sharma , Dexuan Cui , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , "David S. Miller" , Eric Dumazet , linux-rdma@vger.kernel.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Long Li , stable@vger.kernel.org Subject: Re: [Patch v3] net: mana: Batch ringing RX queue doorbell on receiving packets Message-ID: <20230629091129.19217388@kernel.org> In-Reply-To: <36c95dd6babb2202f70594d5dde13493af62dcad.camel@redhat.com> References: <1687823827-15850-1-git-send-email-longli@linuxonhyperv.com> <36c95dd6babb2202f70594d5dde13493af62dcad.camel@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 29 Jun 2023 10:42:34 +0200 Paolo Abeni wrote: > > While we are making changes in this code path, change the code for > > ringing doorbell to set the WQE_COUNT to 0 for Receive Queue. The > > hardware specification specifies that it should set to 0. Although > > currently the hardware doesn't enforce the check, in the future releases > > it may do. And please split this cleanup into a separate patch, it doesn't sound like it has to be done as part of the optimization.