* [PATCH] Add MODULE_FIRMWARE() for FIRMWARE_TG357766.
@ 2023-06-28 0:13 Tobias Heider
2023-06-28 1:31 ` Michael Chan
2023-06-29 17:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 6+ messages in thread
From: Tobias Heider @ 2023-06-28 0:13 UTC (permalink / raw)
To: Siva Reddy Kallam
Cc: Prashant Sreedharan, Michael Chan, netdev, David S. Miller,
linux-kernel
Fixes a bug where on the M1 mac mini initramfs-tools fails to
include the necessary firmware into the initrd.
Signed-off-by: Tobias Heider <me@tobhe.de>
---
drivers/net/ethernet/broadcom/tg3.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index 58747292521d..a52cf9aae498 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -224,6 +224,7 @@ MODULE_AUTHOR("David S. Miller (davem@redhat.com) and Jeff Garzik (jgarzik@pobox
MODULE_DESCRIPTION("Broadcom Tigon3 ethernet driver");
MODULE_LICENSE("GPL");
MODULE_FIRMWARE(FIRMWARE_TG3);
+MODULE_FIRMWARE(FIRMWARE_TG357766);
MODULE_FIRMWARE(FIRMWARE_TG3TSO);
MODULE_FIRMWARE(FIRMWARE_TG3TSO5);
--
2.39.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] Add MODULE_FIRMWARE() for FIRMWARE_TG357766.
2023-06-28 0:13 [PATCH] Add MODULE_FIRMWARE() for FIRMWARE_TG357766 Tobias Heider
@ 2023-06-28 1:31 ` Michael Chan
2023-06-29 13:05 ` Paolo Abeni
2023-06-29 17:00 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 6+ messages in thread
From: Michael Chan @ 2023-06-28 1:31 UTC (permalink / raw)
To: Tobias Heider
Cc: Siva Reddy Kallam, Prashant Sreedharan, Michael Chan, netdev,
David S. Miller, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 304 bytes --]
On Tue, Jun 27, 2023 at 5:13 PM Tobias Heider <me@tobhe.de> wrote:
>
> Fixes a bug where on the M1 mac mini initramfs-tools fails to
> include the necessary firmware into the initrd.
>
> Signed-off-by: Tobias Heider <me@tobhe.de>
Thanks.
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add MODULE_FIRMWARE() for FIRMWARE_TG357766.
2023-06-28 1:31 ` Michael Chan
@ 2023-06-29 13:05 ` Paolo Abeni
2023-06-29 13:37 ` Tobias Heider
0 siblings, 1 reply; 6+ messages in thread
From: Paolo Abeni @ 2023-06-29 13:05 UTC (permalink / raw)
To: Michael Chan, Tobias Heider
Cc: Siva Reddy Kallam, Prashant Sreedharan, Michael Chan, netdev,
David S. Miller, linux-kernel
On Tue, 2023-06-27 at 18:31 -0700, Michael Chan wrote:
> On Tue, Jun 27, 2023 at 5:13 PM Tobias Heider <me@tobhe.de> wrote:
> >
> > Fixes a bug where on the M1 mac mini initramfs-tools fails to
> > include the necessary firmware into the initrd.
> >
> > Signed-off-by: Tobias Heider <me@tobhe.de>
>
> Thanks.
> Reviewed-by: Michael Chan <michael.chan@broadcom.com>
This is a borderline situation, but ...
Is there a suitable 'Fixes:' tag we can add here?
Thanks!
Paolo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add MODULE_FIRMWARE() for FIRMWARE_TG357766.
2023-06-29 13:05 ` Paolo Abeni
@ 2023-06-29 13:37 ` Tobias Heider
2023-06-29 16:14 ` Jakub Kicinski
0 siblings, 1 reply; 6+ messages in thread
From: Tobias Heider @ 2023-06-29 13:37 UTC (permalink / raw)
To: Paolo Abeni
Cc: Michael Chan, Siva Reddy Kallam, Prashant Sreedharan,
Michael Chan, netdev, David S. Miller, linux-kernel
On Thu, Jun 29, 2023 at 03:05:23PM +0200, Paolo Abeni wrote:
> On Tue, 2023-06-27 at 18:31 -0700, Michael Chan wrote:
> > On Tue, Jun 27, 2023 at 5:13 PM Tobias Heider <me@tobhe.de> wrote:
> > >
> > > Fixes a bug where on the M1 mac mini initramfs-tools fails to
> > > include the necessary firmware into the initrd.
> > >
> > > Signed-off-by: Tobias Heider <me@tobhe.de>
> >
> > Thanks.
> > Reviewed-by: Michael Chan <michael.chan@broadcom.com>
>
> This is a borderline situation, but ...
>
> Is there a suitable 'Fixes:' tag we can add here?
>
> Thanks!
>
> Paolo
>
Would "Fixes: c4dab50697ff ("video: remove unnecessary platform_set_drvdata()")"
work?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Add MODULE_FIRMWARE() for FIRMWARE_TG357766.
2023-06-28 0:13 [PATCH] Add MODULE_FIRMWARE() for FIRMWARE_TG357766 Tobias Heider
2023-06-28 1:31 ` Michael Chan
@ 2023-06-29 17:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-06-29 17:00 UTC (permalink / raw)
To: Tobias Heider; +Cc: siva.kallam, prashant, mchan, netdev, davem, linux-kernel
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 28 Jun 2023 02:13:32 +0200 you wrote:
> Fixes a bug where on the M1 mac mini initramfs-tools fails to
> include the necessary firmware into the initrd.
>
> Signed-off-by: Tobias Heider <me@tobhe.de>
> ---
> drivers/net/ethernet/broadcom/tg3.c | 1 +
> 1 file changed, 1 insertion(+)
Here is the summary with links:
- Add MODULE_FIRMWARE() for FIRMWARE_TG357766.
https://git.kernel.org/netdev/net/c/046f753da614
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-06-29 17:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-28 0:13 [PATCH] Add MODULE_FIRMWARE() for FIRMWARE_TG357766 Tobias Heider
2023-06-28 1:31 ` Michael Chan
2023-06-29 13:05 ` Paolo Abeni
2023-06-29 13:37 ` Tobias Heider
2023-06-29 16:14 ` Jakub Kicinski
2023-06-29 17:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).