From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FD27134B0 for ; Thu, 29 Jun 2023 18:06:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 541ACC433C8; Thu, 29 Jun 2023 18:06:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688062009; bh=7Ks0hv1XTuN4Iv5JUqC6lvcE81ZceWI4a8y/7x9CqXM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XiK70HkCWF5/YqgANZx6p+vSgxyyYySejOV90UW5Cteyg9yOE12bXdoaIUi0cs6vE EhOv/rqi+Q86KbzKnbN1a69O7Jw82DKwXBDvUpcNBfPDnYfrU8TJwRK5PARlT9j6Mh AuAjvMCIcPeXAmOLkn02O/miOgo8aafKMJ/h282aBbkrNr4yngH45sYQD8fJFRR4z8 4R3ILpuJ+RhPEnsv8RWtqYSnSXdZzmnEkTN4MIkdmzrsNxUABmHZq6BbZUGfr6mFq/ 3fohSdcMPq1svVgzCdnzM6N5L9uUBMT0+npsS2h+89gDwJwhlTFzUlYC1ETX1Zs4E/ l0nCV4+zM/oPw== Date: Thu, 29 Jun 2023 11:06:48 -0700 From: Jakub Kicinski To: Richard Cochran Cc: Rahul Rameshbabu , netdev@vger.kernel.org, Paolo Abeni , Saeed Mahameed , Gal Pressman , "David S. Miller" , lkft-triage@lists.linaro.org, "LTP List" , Nathan Chancellor , Naresh Kamboju , Linux Kernel Functional Testing Subject: Re: [PATCH net v1] ptp: Make max_phase_adjustment sysfs device attribute invisible when not supported Message-ID: <20230629110648.4b510cf6@kernel.org> In-Reply-To: <20230627232139.213130-1-rrameshbabu@nvidia.com> References: <20230627232139.213130-1-rrameshbabu@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 27 Jun 2023 16:21:39 -0700 Rahul Rameshbabu wrote: > The .adjphase operation is an operation that is implemented only by certain > PHCs. The sysfs device attribute node for querying the maximum phase > adjustment supported should not be exposed on devices that do not support > .adjphase. Richard, ack?