* [PATCH] Bluetooth: coredump: fix building with coredump disabled
@ 2023-07-03 11:30 Arnd Bergmann
2023-07-05 23:00 ` patchwork-bot+bluetooth
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2023-07-03 11:30 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg, Chris Lu, Sean Wang, Jing Cai,
Abhishek Pandit-Subedi, Manish Mandlik
Cc: Arnd Bergmann, Luiz Augusto von Dentz, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Brian Gix,
Pauli Virtanen, Iulia Tanasescu, linux-bluetooth, netdev,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The btmtk driver uses an IS_ENABLED() check to conditionally compile
the coredump support, but this fails to build because the hdev->dump
member is in an #ifdef:
drivers/bluetooth/btmtk.c: In function 'btmtk_process_coredump':
drivers/bluetooth/btmtk.c:386:30: error: 'struct hci_dev' has no member named 'dump'
386 | schedule_delayed_work(&hdev->dump.dump_timeout,
| ^~
The struct member doesn't really make a huge difference in the total size,
so just remove the #ifdef around it to avoid adding similar checks
around each user.
Fixes: 872f8c253cb9e ("Bluetooth: btusb: mediatek: add MediaTek devcoredump support")
Fixes: 9695ef876fd12 ("Bluetooth: Add support for hci devcoredump")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
include/net/bluetooth/hci_core.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
index c0ca3f869c923..491ab83ccafc9 100644
--- a/include/net/bluetooth/hci_core.h
+++ b/include/net/bluetooth/hci_core.h
@@ -593,9 +593,7 @@ struct hci_dev {
const char *fw_info;
struct dentry *debugfs;
-#ifdef CONFIG_DEV_COREDUMP
struct hci_devcoredump dump;
-#endif
struct device dev;
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Bluetooth: coredump: fix building with coredump disabled
2023-07-03 11:30 [PATCH] Bluetooth: coredump: fix building with coredump disabled Arnd Bergmann
@ 2023-07-05 23:00 ` patchwork-bot+bluetooth
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+bluetooth @ 2023-07-05 23:00 UTC (permalink / raw)
To: Arnd Bergmann
Cc: marcel, johan.hedberg, chris.lu, sean.wang, jing.cai,
abhishekpandit, mmandlik, arnd, luiz.dentz, davem, edumazet, kuba,
pabeni, brian.gix, pav, iulia.tanasescu, linux-bluetooth, netdev,
linux-kernel
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
On Mon, 3 Jul 2023 13:30:48 +0200 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The btmtk driver uses an IS_ENABLED() check to conditionally compile
> the coredump support, but this fails to build because the hdev->dump
> member is in an #ifdef:
>
> drivers/bluetooth/btmtk.c: In function 'btmtk_process_coredump':
> drivers/bluetooth/btmtk.c:386:30: error: 'struct hci_dev' has no member named 'dump'
> 386 | schedule_delayed_work(&hdev->dump.dump_timeout,
> | ^~
>
> [...]
Here is the summary with links:
- Bluetooth: coredump: fix building with coredump disabled
https://git.kernel.org/bluetooth/bluetooth-next/c/6ca03ff0da3e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-05 23:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-03 11:30 [PATCH] Bluetooth: coredump: fix building with coredump disabled Arnd Bergmann
2023-07-05 23:00 ` patchwork-bot+bluetooth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).