From: Jakub Kicinski <kuba@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 0/2] Fix mangled link-local MAC DAs with SJA1105 DSA
Date: Mon, 3 Jul 2023 13:33:55 -0700 [thread overview]
Message-ID: <20230703133355.479c6651@kernel.org> (raw)
In-Reply-To: <20230629141453.1112919-1-vladimir.oltean@nxp.com>
On Thu, 29 Jun 2023 17:14:51 +0300 Vladimir Oltean wrote:
> The SJA1105 hardware tagging protocol is weird and will put DSA
> information (source port, switch ID) in the MAC DA of the packets sent
> to the CPU, and then send some additional (meta) packets which contain
> the original bytes from the previous packet's MAC DA.
>
> The tagging protocol driver contains logic to handle this, but the meta
> frames are optional functionality, and there are configurations when
> they aren't received (no PTP RX timestamping). Thus, the MAC DA from
> packets sent to the stack is not correct in all cases.
>
> Also, during testing it was found that the MAC DA patching procedure was
> incorrect.
>
> The investigation comes as a result of this discussion with Paolo:
> https://lore.kernel.org/netdev/f494387c8d55d9b1d5a3e88beedeeb448f2e6cc3.camel@redhat.com/
This series got eaten by vger, I think. Could you repost?
prev parent reply other threads:[~2023-07-03 20:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230629141453.1112919-1-vladimir.oltean@nxp.com>
[not found] ` <20230629141453.1112919-3-vladimir.oltean@nxp.com>
2023-06-30 13:35 ` [PATCH net 2/2] net: dsa: sja1105: always enable the send_meta options Simon Horman
2023-06-30 16:53 ` Vladimir Oltean
2023-06-30 17:38 ` Simon Horman
2023-07-02 14:39 ` Florian Fainelli
[not found] ` <20230629141453.1112919-2-vladimir.oltean@nxp.com>
2023-06-30 13:29 ` [PATCH net 1/2] net: dsa: tag_sja1105: fix MAC DA patching from meta frames Simon Horman
2023-07-02 14:37 ` Florian Fainelli
2023-07-03 20:33 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230703133355.479c6651@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).