Re: [PATCH 0/4] igb: Add support for AF_XDP zero-copy

Maciej Fijalkowski
2023-07-04T15:37:43Z

On Tue, Jul 04, 2023 at 11:59:11AM +0200, Sriram Yagnaraman wrote:

Hi Sriram,

> Disclaimer: My first patches to Intel drivers, implemented AF_XDP
> zero-copy feature which seemed to be missing for igb. Not sure if it was
> a conscious choice to not spend time implementing this for older
> devices, nevertheless I send them to the list for review.
>
> The first couple of patches adds helper funcctions to prepare for AF_XDP
> zero-copy support which comes in the last couple of patches, one each
> for Rx and TX paths.

please include perf numbers in cover letter, CC AF_XDP maintainers and use
batch XSK APIs: xsk_buff_alloc_batch(), xsk_tx_peek_release_desc_batch().

Thanks!

>
> Sriram Yagnaraman (4):
> igb: prepare for AF_XDP zero-copy support
> igb: Introduce txrx ring enable/disable functions
> igb: add AF_XDP zero-copy Rx support
> igb: add AF_XDP zero-copy Tx support
>
> drivers/net/ethernet/intel/igb/Makefile | 2 +-
> drivers/net/ethernet/intel/igb/igb.h | 52 ++-
> drivers/net/ethernet/intel/igb/igb_main.c | 178 +++++++--
> drivers/net/ethernet/intel/igb/igb_xsk.c | 434 ++++++++++++++++++++++
> 4 files changed, 633 insertions(+), 33 deletions(-)
> create mode 100644 drivers/net/ethernet/intel/igb/igb_xsk.c
>
> --
> 2.34.1
>
>