* [PATCH net] net/mlx5e: fix double free in macsec_fs_tx_create_crypto_table_groups
@ 2023-07-04 7:06 Zhengchao Shao
2023-07-04 17:04 ` Simon Horman
2023-07-05 5:39 ` Leon Romanovsky
0 siblings, 2 replies; 3+ messages in thread
From: Zhengchao Shao @ 2023-07-04 7:06 UTC (permalink / raw)
To: netdev, linux-rdma, davem, edumazet, kuba, pabeni
Cc: borisp, saeedm, leon, raeds, ehakim, liorna, nathan, weiyongjun1,
yuehaibing, shaozhengchao
In function macsec_fs_tx_create_crypto_table_groups(), when the ft->g
memory is successfully allocated but the 'in' memory fails to be
allocated, the memory pointed to by ft->g is released once. And in function
macsec_fs_tx_create(), macsec_fs_tx_destroy() is called to release the
memory pointed to by ft->g again. This will cause double free problem.
Fixes: e467b283ffd5 ("net/mlx5e: Add MACsec TX steering rules")
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
---
drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec_fs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec_fs.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec_fs.c
index 7fc901a6ec5f..414e28584881 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec_fs.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec_fs.c
@@ -161,6 +161,7 @@ static int macsec_fs_tx_create_crypto_table_groups(struct mlx5e_flow_table *ft)
if (!in) {
kfree(ft->g);
+ ft->g = NULL;
return -ENOMEM;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] net/mlx5e: fix double free in macsec_fs_tx_create_crypto_table_groups
2023-07-04 7:06 [PATCH net] net/mlx5e: fix double free in macsec_fs_tx_create_crypto_table_groups Zhengchao Shao
@ 2023-07-04 17:04 ` Simon Horman
2023-07-05 5:39 ` Leon Romanovsky
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2023-07-04 17:04 UTC (permalink / raw)
To: Zhengchao Shao
Cc: netdev, linux-rdma, davem, edumazet, kuba, pabeni, borisp, saeedm,
leon, raeds, ehakim, liorna, nathan, weiyongjun1, yuehaibing
On Tue, Jul 04, 2023 at 03:06:40PM +0800, Zhengchao Shao wrote:
> In function macsec_fs_tx_create_crypto_table_groups(), when the ft->g
> memory is successfully allocated but the 'in' memory fails to be
> allocated, the memory pointed to by ft->g is released once. And in function
> macsec_fs_tx_create(), macsec_fs_tx_destroy() is called to release the
> memory pointed to by ft->g again. This will cause double free problem.
>
> Fixes: e467b283ffd5 ("net/mlx5e: Add MACsec TX steering rules")
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] net/mlx5e: fix double free in macsec_fs_tx_create_crypto_table_groups
2023-07-04 7:06 [PATCH net] net/mlx5e: fix double free in macsec_fs_tx_create_crypto_table_groups Zhengchao Shao
2023-07-04 17:04 ` Simon Horman
@ 2023-07-05 5:39 ` Leon Romanovsky
1 sibling, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2023-07-05 5:39 UTC (permalink / raw)
To: Zhengchao Shao
Cc: netdev, linux-rdma, davem, edumazet, kuba, pabeni, borisp, saeedm,
raeds, ehakim, liorna, nathan, weiyongjun1, yuehaibing
On Tue, Jul 04, 2023 at 03:06:40PM +0800, Zhengchao Shao wrote:
> In function macsec_fs_tx_create_crypto_table_groups(), when the ft->g
> memory is successfully allocated but the 'in' memory fails to be
> allocated, the memory pointed to by ft->g is released once. And in function
> macsec_fs_tx_create(), macsec_fs_tx_destroy() is called to release the
> memory pointed to by ft->g again. This will cause double free problem.
This is perfect example, why it is anti-pattern to have one global
destroy function like macsec_fs_tx_destroy(), which hides multiple
class of errors: wrong release order, double free e.t.c
>
> Fixes: e467b283ffd5 ("net/mlx5e: Add MACsec TX steering rules")
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec_fs.c | 1 +
> 1 file changed, 1 insertion(+)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-05 5:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-04 7:06 [PATCH net] net/mlx5e: fix double free in macsec_fs_tx_create_crypto_table_groups Zhengchao Shao
2023-07-04 17:04 ` Simon Horman
2023-07-05 5:39 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).