From: Lee Jones <lee@kernel.org>
To: Zheng Wang <zyytlz.wz@163.com>
Cc: s.shtylyov@omp.ru, davem@davemloft.net, linyunsheng@huawei.com,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
hackerzheng666@gmail.com, 1395428693sheep@gmail.com,
alex000young@gmail.com
Subject: Re: [PATCH net v3] net: ravb: Fix possible UAF bug in ravb_remove
Date: Wed, 5 Jul 2023 09:05:45 +0100 [thread overview]
Message-ID: <20230705080545.GA589018@google.com> (raw)
In-Reply-To: <20230311180630.4011201-1-zyytlz.wz@163.com>
On Sun, 12 Mar 2023, Zheng Wang wrote:
> In ravb_probe, priv->work was bound with ravb_tx_timeout_work.
> If timeout occurs, it will start the work. And if we call
> ravb_remove without finishing the work, there may be a
> use-after-free bug on ndev.
>
> Fix it by finishing the job before cleanup in ravb_remove.
>
> Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
> Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> ---
> v3:
> - fix typo in commit message
> v2:
> - stop dev_watchdog so that handle no more timeout work suggested by Yunsheng Lin,
> add an empty line to make code clear suggested by Sergey Shtylyov
> ---
> drivers/net/ethernet/renesas/ravb_main.c | 4 ++++
> 1 file changed, 4 insertions(+)
Was a follow-up to this ever sent?
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-07-05 8:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 18:06 [PATCH net v3] net: ravb: Fix possible UAF bug in ravb_remove Zheng Wang
2023-03-12 20:26 ` Sergey Shtylyov
2023-03-13 3:00 ` Zheng Hacker
2023-03-13 1:15 ` Yunsheng Lin
2023-03-13 3:02 ` Zheng Hacker
2023-03-13 3:32 ` Yunsheng Lin
2023-03-13 9:34 ` Zheng Hacker
2023-07-19 21:04 ` Sergey Shtylyov
2023-03-13 22:39 ` Jakub Kicinski
2023-03-14 1:24 ` Zheng Hacker
2023-07-05 8:05 ` Lee Jones [this message]
2023-07-10 11:42 ` Lee Jones
2023-07-10 16:15 ` Jakub Kicinski
2023-07-11 21:20 ` Sergey Shtylyov
2023-07-12 11:56 ` Lee Jones
2023-07-15 16:07 ` Zheng Hacker
2023-07-15 20:48 ` Sergey Shtylyov
2023-07-16 2:11 ` Zheng Hacker
2023-07-16 3:14 ` Zheng Hacker
2023-07-17 13:04 ` Lee Jones
2023-07-17 13:21 ` Zheng Hacker
2023-07-24 9:20 ` Lee Jones
2023-07-25 2:26 ` Zheng Hacker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230705080545.GA589018@google.com \
--to=lee@kernel.org \
--cc=1395428693sheep@gmail.com \
--cc=alex000young@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hackerzheng666@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=s.shtylyov@omp.ru \
--cc=zyytlz.wz@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).