From: Jakub Kicinski <kuba@kernel.org>
To: Victor Nogueira <victor@mojatatu.com>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, pctammela@mojatatu.com,
simon.horman@corigine.com, kernel@mojatatu.com
Subject: Re: [PATCH net v2 1/5] net: sched: cls_bpf: Undo tcf_bind_filter in case of an error
Date: Wed, 5 Jul 2023 10:08:12 -0700 [thread overview]
Message-ID: <20230705100812.011ab384@kernel.org> (raw)
In-Reply-To: <20230705134329.102345-2-victor@mojatatu.com>
On Wed, 5 Jul 2023 10:43:25 -0300 Victor Nogueira wrote:
> static int cls_bpf_set_parms(struct net *net, struct tcf_proto *tp,
> struct cls_bpf_prog *prog, unsigned long base,
> struct nlattr **tb, struct nlattr *est, u32 flags,
> - struct netlink_ext_ack *extack)
> + bool *bound_to_filter, struct netlink_ext_ack *extack)
Output argument, and an 8th argument of a function at that is too ugly.
Please find a better way to fix this.
--
pw-bot: cr
next prev parent reply other threads:[~2023-07-05 17:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 13:43 [PATCH net v2 0/5] net: sched: Undo tcf_bind_filter in case of errors in set callbacks Victor Nogueira
2023-07-05 13:43 ` [PATCH net v2 1/5] net: sched: cls_bpf: Undo tcf_bind_filter in case of an error Victor Nogueira
2023-07-05 17:08 ` Jakub Kicinski [this message]
2023-07-05 13:43 ` [PATCH net v2 2/5] net: sched: cls_matchall: Undo tcf_bind_filter in case of failure after mall_set_parms Victor Nogueira
2023-07-05 13:43 ` [PATCH net v2 3/5] net: sched: cls_u32: Undo tcf_bind_filter if u32_replace_hw_knode Victor Nogueira
2023-07-05 13:43 ` [PATCH net v2 4/5] net: sched: cls_u32: Undo refcount decrement in case update failed Victor Nogueira
2023-07-05 13:43 ` [PATCH net v2 5/5] net: sched: cls_flower: Undo tcf_bind_filter if fl_set_key fails Victor Nogueira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230705100812.011ab384@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kernel@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pctammela@mojatatu.com \
--cc=simon.horman@corigine.com \
--cc=victor@mojatatu.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).