From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97B04746C for ; Wed, 5 Jul 2023 12:16:32 +0000 (UTC) Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72A20BE; Wed, 5 Jul 2023 05:16:30 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1qH1Qp-00062P-U5; Wed, 05 Jul 2023 14:16:27 +0200 Date: Wed, 5 Jul 2023 14:16:27 +0200 From: Florian Westphal To: Thadeu Lima de Souza Cascardo Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, Pablo Neira Ayuso Subject: Re: [PATCH] netfilter: nf_tables: do not ignore genmask when looking up chain by id Message-ID: <20230705121627.GC19489@breakpoint.cc> References: <20230705121255.746628-1-cascardo@canonical.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230705121255.746628-1-cascardo@canonical.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Thadeu Lima de Souza Cascardo wrote: > When adding a rule to a chain referring to its ID, if that chain had been > deleted on the same batch, the rule might end up referring to a deleted > chain. Reviewed-by: Florian Westphal