From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E90F13AEF for ; Wed, 5 Jul 2023 20:55:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82782C433C7; Wed, 5 Jul 2023 20:55:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688590549; bh=uiTvJCau7YJw9n0j5AlyOXFdzLt/ldvFjBcrnv8HuVA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ajxd1wErIXQtvCUd0gJSO/SNM13g6HK2w4YkygqktkFTco9dijPC6jarBfTiYrzJr KxcEUs2LAPZfuf5VYreCIYDtK7Zx6O51GLZyb+V1En0UPzJglqi+4zDypRtIbPh4+8 ZJ7TMdsIamP4N3+QC6XExX5Ihl+HPR06fkF0GVv97mlM+eeuv01qDhQH+8qJC3xQ2x xmTfN+RDB5vYg+YILcjfWKKNlRrcgRk4IhudMpWQp87+QAb4Jsyc3rsc5rI0bY877u Npft+iAS+sW3VT7xCfl9MUDOmCqPf4XJiqoETlum7tcRJZ3fIc0NLlHPsZXuEvlpVp 3w0fuDKC8U0YA== Date: Wed, 5 Jul 2023 13:55:48 -0700 From: Jakub Kicinski To: Hannes Reinecke Cc: Sagi Grimberg , Keith Busch , Christoph Hellwig , linux-nvme@lists.infradead.org, Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org Subject: Re: [PATCH 4/5] net/tls: split tls_rx_reader_lock Message-ID: <20230705135548.52db9949@kernel.org> In-Reply-To: <0e230fdf-6af6-926f-305e-2f34ac6a6812@suse.de> References: <20230703090444.38734-1-hare@suse.de> <20230703090444.38734-5-hare@suse.de> <1ebc60c1-c094-98a0-5735-635a8af5bf63@grimberg.me> <0e230fdf-6af6-926f-305e-2f34ac6a6812@suse.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 3 Jul 2023 12:21:32 +0200 Hannes Reinecke wrote: > > Nit: I still think tls_rx_reader_enter/tls_rx_reader_exit are more > > appropriate names. > > I don't mind either way, but I've interpreted the comments from Jakub > that he'd like this naming better. > > Jakub? Slight preference for enter/leave (leave rather than exit).