From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1785A1548E for ; Wed, 5 Jul 2023 21:29:33 +0000 (UTC) Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6129A19BB; Wed, 5 Jul 2023 14:29:32 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1qHA41-0000eq-Po; Wed, 05 Jul 2023 23:29:29 +0200 Date: Wed, 5 Jul 2023 23:29:29 +0200 From: Florian Westphal To: Thadeu Lima de Souza Cascardo Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, Pablo Neira Ayuso , Florian Westphal Subject: Re: [PATCH v2] netfilter: nf_tables: prevent OOB access in nft_byteorder_eval Message-ID: <20230705212929.GI3751@breakpoint.cc> References: <20230705201232.GG3751@breakpoint.cc> <20230705210535.943194-1-cascardo@canonical.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230705210535.943194-1-cascardo@canonical.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Thadeu Lima de Souza Cascardo wrote: > When evaluating byteorder expressions with size 2, a union with 32-bit and > 16-bit members is used. Since the 16-bit members are aligned to 32-bit, > the array accesses will be out-of-bounds. > > It may lead to a stack-out-of-bounds access like the one below: Reviewed-by: Florian Westphal