From: Leon Romanovsky <leon@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org,
Sridhar Samudrala <sridhar.samudrala@intel.com>,
Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>,
Bharathi Sreenivas <bharathi.sreenivas@intel.com>
Subject: Re: [PATCH net 1/2] ice: Fix max_rate check while configuring TX rate limits
Date: Thu, 6 Jul 2023 10:50:42 +0300 [thread overview]
Message-ID: <20230706075042.GQ6455@unreal> (raw)
In-Reply-To: <20230705201346.49370-2-anthony.l.nguyen@intel.com>
On Wed, Jul 05, 2023 at 01:13:45PM -0700, Tony Nguyen wrote:
> From: Sridhar Samudrala <sridhar.samudrala@intel.com>
>
> Remove incorrect check in ice_validate_mqprio_opt() that limits
> filter configuration when sum of max_rates of all TCs exceeds
> the link speed. The max rate of each TC is unrelated to value
> used by other TCs and is valid as long as it is less than link
> speed.
>
> Fixes: fbc7b27af0f9 ("ice: enable ndo_setup_tc support for mqprio_qdisc")
> Signed-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com>
> Signed-off-by: Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>
> Tested-by: Bharathi Sreenivas <bharathi.sreenivas@intel.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_main.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2023-07-06 7:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 20:13 [PATCH net 0/2][pull request] Intel Wired LAN Driver Updates 2023-07-05 (ice) Tony Nguyen
2023-07-05 20:13 ` [PATCH net 1/2] ice: Fix max_rate check while configuring TX rate limits Tony Nguyen
2023-07-06 7:50 ` Leon Romanovsky [this message]
2023-07-05 20:13 ` [PATCH net 2/2] ice: Fix tx queue rate limit when TCs are configured Tony Nguyen
2023-07-06 7:50 ` Leon Romanovsky
2023-07-07 2:20 ` [PATCH net 0/2][pull request] Intel Wired LAN Driver Updates 2023-07-05 (ice) patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230706075042.GQ6455@unreal \
--to=leon@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=bharathi.sreenivas@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sridhar.samudrala@intel.com \
--cc=sudheer.mogilappagari@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).