netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Junfeng Guo <junfeng.guo@intel.com>
Cc: netdev@vger.kernel.org, jeroendb@google.com,
	pkaligineedi@google.com, shailend@google.com,
	haiyue.wang@intel.com
Subject: Re: [PATCH net] gve: Set default duplex configuration to full
Date: Thu, 6 Jul 2023 11:03:01 +0300	[thread overview]
Message-ID: <20230706080301.GU6455@unreal> (raw)
In-Reply-To: <20230706044128.2726747-1-junfeng.guo@intel.com>

On Thu, Jul 06, 2023 at 12:41:28PM +0800, Junfeng Guo wrote:
> Current duplex mode was unset in the driver, resulting in the default
> parameter being set to 0, which corresponds to half duplex. It might
> mislead users to have incorrect expectation about the driver's
> transmission capabilities.
> Set the default duplex configuration to full, as the driver runs in
> full duplex mode at this point.
> 
> Fixes: 7e074d5a76ca ("gve: Enable Link Speed Reporting in the driver.")
> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> ---
>  drivers/net/ethernet/google/gve/gve_ethtool.c | 3 +++
>  1 file changed, 3 insertions(+)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>

  reply	other threads:[~2023-07-06  8:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-06  4:41 [PATCH net] gve: Set default duplex configuration to full Junfeng Guo
2023-07-06  8:03 ` Leon Romanovsky [this message]
2023-07-07  2:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230706080301.GU6455@unreal \
    --to=leon@kernel.org \
    --cc=haiyue.wang@intel.com \
    --cc=jeroendb@google.com \
    --cc=junfeng.guo@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pkaligineedi@google.com \
    --cc=shailend@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).