From: Jakub Kicinski <kuba@kernel.org>
To: Wang Ming <machel@vivo.com>
Cc: Jon Maloy <jmaloy@redhat.com>, Ying Xue <ying.xue@windriver.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net,
linux-kernel@vger.kernel.org, opensource.kernel@vivo.com
Subject: Re: [PATCH v1] net:tipc:Remove repeated initialization
Date: Thu, 6 Jul 2023 08:47:29 -0700 [thread overview]
Message-ID: <20230706084729.12ed5725@kernel.org> (raw)
In-Reply-To: <20230706134226.9119-1-machel@vivo.com>
On Thu, 6 Jul 2023 21:42:09 +0800 Wang Ming wrote:
> The original code initializes 'tmp' twice,
> which causes duplicate initialization issue.
> To fix this, we remove the second initialization
> of 'tmp' and use 'parent' directly forsubsequent
> operations.
>
> Signed-off-by: Wang Ming <machel@vivo.com>
Please stop sending the "remove repeated initialization" patches
to networking, thanks.
next prev parent reply other threads:[~2023-07-06 15:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 13:42 [PATCH v1] net:tipc:Remove repeated initialization Wang Ming
2023-07-06 15:47 ` Jakub Kicinski [this message]
2023-07-06 17:13 ` Christophe JAILLET
2023-07-07 1:24 ` 回复: " 王明-软件底层技术部
2023-07-07 5:24 ` Christophe JAILLET
2023-07-07 6:42 ` net: tipc: Remove repeated “initialization” in tipc_group_add_to_tree() Markus Elfring
2023-07-07 10:25 ` Tung Quang Nguyen
2023-07-07 1:21 ` 回复: [PATCH v1] net:tipc:Remove repeated initialization 王明-软件底层技术部
2023-07-07 1:54 ` Jakub Kicinski
2023-07-06 18:50 ` [PATCH] net: tipc: Remove repeated “initialization” Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230706084729.12ed5725@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jmaloy@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=machel@vivo.com \
--cc=netdev@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=pabeni@redhat.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).