From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7D82BA49 for ; Thu, 6 Jul 2023 17:23:22 +0000 (UTC) Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80FE01BEC for ; Thu, 6 Jul 2023 10:23:21 -0700 (PDT) Received: by mail-pg1-x52d.google.com with SMTP id 41be03b00d2f7-517ab9a4a13so732402a12.1 for ; Thu, 06 Jul 2023 10:23:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; t=1688664200; x=1691256200; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3w6eM1h+0P8X1QDbGu2Q17kb8M2qnV/qp1NskbLt6Z0=; b=BUPdN44Pqpap981nerjdz0tmWFl99Jhx/pTjf/uNWurNdXG0E8Aya+43lFIjrQakt3 aTVTSRMtB6Qre/swdUDlKkB51mf/8gU0WbwhkChkq3WHXezkMH74Qiea6VOZMcvmFixL m/qNgag4jj6XXQKOE7w2+lkZSjvJlz02Fh6yg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688664200; x=1691256200; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3w6eM1h+0P8X1QDbGu2Q17kb8M2qnV/qp1NskbLt6Z0=; b=V91S08OLXCFL0mD+LAHNiZlazvMvu1tCkXG0/C2dfdjY7bi/oNCakmcEj6Yr4yIEU9 akrSyHV2Ft4SNIHtFuY/7CfAzYtP3bPP5hKTu7HqaaeDvUjl56Nkxgu1MeIuQtGZLqbw Jw/9GmEYiccLrsDU9fIgcRHNo+3IO3NetfCMy2ArVvMsuBNC12MWbONgHB32QTSL0Dcr TJCgXB8J3DKbPoxj6YgI1aM/NXZRoZOC/n58ZEvofWr8V0F6tH/9t+g2554JsrNkO90s 0dNae77/34YzK9hIWJHTEIO5L5e6AyycTrF5aoynHe2cRXPF4uKQjVYMdiNu8tXdtoTR tKMg== X-Gm-Message-State: ABy/qLaaQdSZuLxjS1/rX5tBqSd3pgl70RE1bVtIcih74uBO64Wq5ibX QD/x7ms0eYQUQc8m+PpdTkDujwgVPVxTIrerbMLOwQ== X-Google-Smtp-Source: APBJJlEnFoNgR0Za1gb6swgE7IdNVSOCrgicMUPGnWTnn3YySvdOVMl+LhVdLLfoOXeS1V3o/KJ5/A== X-Received: by 2002:a05:6a20:9384:b0:130:3c8b:4204 with SMTP id x4-20020a056a20938400b001303c8b4204mr2118043pzh.8.1688664200464; Thu, 06 Jul 2023 10:23:20 -0700 (PDT) Received: from localhost ([2601:644:200:aea:502d:5846:fd1f:55e7]) by smtp.gmail.com with ESMTPSA id p22-20020aa78616000000b0067903510abbsm1528509pfn.163.2023.07.06.10.23.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jul 2023 10:23:20 -0700 (PDT) From: Ivan Babrou To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@cloudflare.com, Ivan Babrou , Willem de Bruijn , "David S. Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Neil Horman , Satoru Moriya Subject: [PATCH] udp6: add a missing call into udp_fail_queue_rcv_skb tracepoint Date: Thu, 6 Jul 2023 10:22:36 -0700 Message-ID: <20230706172237.28341-1-ivan@cloudflare.com> X-Mailer: git-send-email 2.41.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net The tracepoint has existed for 12 years, but it only covered udp over the legacy IPv4 protocol. Having it enabled for udp6 removes the unnecessary difference in error visibility. Signed-off-by: Ivan Babrou Fixes: 296f7ea75b45 ("udp: add tracepoints for queueing skb to rcvbuf") --- net/ipv6/udp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c index e5a337e6b970..debb98fb23c0 100644 --- a/net/ipv6/udp.c +++ b/net/ipv6/udp.c @@ -45,6 +45,7 @@ #include #include #include +#include #include #include #include @@ -680,6 +681,7 @@ static int __udpv6_queue_rcv_skb(struct sock *sk, struct sk_buff *skb) } UDP6_INC_STATS(sock_net(sk), UDP_MIB_INERRORS, is_udplite); kfree_skb_reason(skb, drop_reason); + trace_udp_fail_queue_rcv_skb(rc, sk); return -1; } -- 2.41.0