netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Niklas Schnelle <schnelle@linux.ibm.com>
To: Paolo Abeni <pabeni@redhat.com>,
	Alexandra Winter <wintera@linux.ibm.com>,
	Wenjia Zhang <wenjia@linux.ibm.com>,
	Jan Karcher <jaka@linux.ibm.com>,
	Stefan Raspl <raspl@linux.ibm.com>,
	"David S. Miller" <davem@davemloft.net>
Cc: linux-s390@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH net v2 0/3] s390/ism: Fixes to client handling
Date: Fri,  7 Jul 2023 12:56:19 +0200	[thread overview]
Message-ID: <20230707105622.3332261-1-schnelle@linux.ibm.com> (raw)

Hi networking developers,

This is v2 of the patch previously titled "s390/ism: Detangle ISM client
IRQ and event forwarding". As suggested by Paolo Abeni I split the patch
up. While doing so I noticed another problem that was fixed by this patch
concerning the way the workqueues access the client structs. This means the
second patch turning the workqueues into simple direct calls also fixes
a problem. Finally I split off a third patch just for fixing
ism_unregister_client()s error path.

The code after these 3 patches is identical to the result of the v1 patch
except that I also turned the dev_err() for still registered DMBs into
a WARN().

Thanks,
Niklas

Changes since v1:
- Split into three patches (Paolo Abeni)
- Turned the dev_err() in ism_unregsiter_client() on still registered DMBs
  into a WARN() as it should only happen due to client bugs.

Niklas Schnelle (3):
  s390/ism: Fix locking for forwarding of IRQs and events to clients
  s390/ism: Fix and simplify add()/remove() callback handling
  s390/ism: Do not unregister clients with registered DMBs

 drivers/s390/net/ism_drv.c | 153 ++++++++++++++++++-------------------
 include/linux/ism.h        |   7 +-
 2 files changed, 74 insertions(+), 86 deletions(-)


base-commit: d528014517f2b0531862c02865b9d4c908019dc4
-- 
2.39.2


             reply	other threads:[~2023-07-07 10:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-07 10:56 Niklas Schnelle [this message]
2023-07-07 10:56 ` [PATCH net v2 1/3] s390/ism: Fix locking for forwarding of IRQs and events to clients Niklas Schnelle
2023-07-07 13:37   ` Alexandra Winter
2023-07-07 14:08     ` Niklas Schnelle
2023-07-07 10:56 ` [PATCH net v2 2/3] s390/ism: Fix and simplify add()/remove() callback handling Niklas Schnelle
2023-07-07 10:56 ` [PATCH net v2 3/3] s390/ism: Do not unregister clients with registered DMBs Niklas Schnelle
2023-07-07 13:46 ` [PATCH net v2 0/3] s390/ism: Fixes to client handling Alexandra Winter
2023-07-07 20:19 ` Wenjia Zhang
2023-07-08  9:13 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230707105622.3332261-1-schnelle@linux.ibm.com \
    --to=schnelle@linux.ibm.com \
    --cc=davem@davemloft.net \
    --cc=jaka@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=raspl@linux.ibm.com \
    --cc=wenjia@linux.ibm.com \
    --cc=wintera@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).