From: Jakub Kicinski <kuba@kernel.org>
To: Yunsheng Lin <linyunsheng@huawei.com>
Cc: <davem@davemloft.net>, <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Alexander Duyck <alexander.duyck@gmail.com>,
Liang Chen <liangchen.linux@gmail.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
<linux-rdma@vger.kernel.org>
Subject: Re: [PATCH v5 RFC 1/6] page_pool: frag API support for 32-bit arch with 64-bit DMA
Date: Fri, 7 Jul 2023 16:59:21 -0700 [thread overview]
Message-ID: <20230707165921.565b1228@kernel.org> (raw)
In-Reply-To: <20230629120226.14854-2-linyunsheng@huawei.com>
On Thu, 29 Jun 2023 20:02:21 +0800 Yunsheng Lin wrote:
> + /* Return error here to avoid mlx5e_page_release_fragmented()
> + * calling page_pool_defrag_page() to write to pp_frag_count
> + * which is overlapped with dma_addr_upper in 'struct page' for
> + * arch with PAGE_POOL_DMA_USE_PP_FRAG_COUNT being true.
> + */
> + if (PAGE_POOL_DMA_USE_PP_FRAG_COUNT) {
> + err = -EINVAL;
> + goto err_free_by_rq_type;
> + }
I told you not to do this in a comment on v4.
Keep the flag in page pool params and let the creation fail.
next prev parent reply other threads:[~2023-07-07 23:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 12:02 [PATCH v5 RFC 0/6] introduce page_pool_alloc() API Yunsheng Lin
2023-06-29 12:02 ` [PATCH v5 RFC 1/6] page_pool: frag API support for 32-bit arch with 64-bit DMA Yunsheng Lin
2023-07-07 23:59 ` Jakub Kicinski [this message]
2023-07-09 12:39 ` Yunsheng Lin
2023-07-10 18:36 ` Jakub Kicinski
2023-07-08 0:01 ` Jakub Kicinski
2023-07-09 12:54 ` Yunsheng Lin
2023-07-10 18:38 ` Jakub Kicinski
2023-07-11 10:59 ` Alexander Lobakin
2023-07-11 16:37 ` Jakub Kicinski
2023-07-11 16:59 ` Alexander Lobakin
2023-07-11 20:09 ` Jakub Kicinski
2023-07-12 12:34 ` Yunsheng Lin
2023-07-12 17:26 ` Jakub Kicinski
2023-07-14 12:16 ` Yunsheng Lin
2023-07-14 13:44 ` Jesper Dangaard Brouer
2023-07-14 17:52 ` Jakub Kicinski
2023-07-17 12:33 ` Yunsheng Lin
2023-07-18 18:16 ` Jakub Kicinski
2023-07-18 18:28 ` Alexander Lobakin
2023-07-19 12:21 ` Yunsheng Lin
2023-06-29 12:02 ` [PATCH v5 RFC 2/6] page_pool: unify frag_count handling in page_pool_is_last_frag() Yunsheng Lin
2023-07-10 14:39 ` Alexander Lobakin
2023-07-11 11:47 ` Yunsheng Lin
2023-06-29 12:02 ` [PATCH v5 RFC 3/6] page_pool: introduce page_pool[_cache]_alloc() API Yunsheng Lin
2023-06-29 12:02 ` [PATCH v5 RFC 4/6] page_pool: remove PP_FLAG_PAGE_FRAG flag Yunsheng Lin
2023-06-29 12:02 ` [PATCH v5 RFC 5/6] page_pool: update document about frag API Yunsheng Lin
2023-06-29 20:30 ` Randy Dunlap
2023-06-29 12:02 ` [PATCH v5 RFC 6/6] net: veth: use newly added page pool API for veth with xdp Yunsheng Lin
2023-06-29 14:26 ` [PATCH v5 RFC 0/6] introduce page_pool_alloc() API Alexander Lobakin
2023-06-30 11:57 ` Yunsheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230707165921.565b1228@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=leon@kernel.org \
--cc=liangchen.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).