From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F18D113AC2 for ; Mon, 10 Jul 2023 20:56:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 525AFC433C8; Mon, 10 Jul 2023 20:56:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689022585; bh=W/TwSzMA9lvXPOhyEuSDDm6DY4xCP5XPunV327xssz4=; h=From:To:Cc:Subject:Date:From; b=gW7ZWb6WKhavX6orRE0ykFNlOip6LJLXm1MXsY+TXbqXl8rrkeqd5CcbpyDeiYuJL Dkh3CYKQ4ZrjgsGtlrST1/cn1nywsbtIcudLNGrz4zK1pUJxE+QAGdOgYAGoZDRpIU mW1+jeTWd05fpxcTmPb0X1s1QqtIjO2UpEsGobO68e0mpYF1/ehecXIxZctNWAWqIG dAPqoQPWs4o6B5q5a32w6ovo9uTfYIJcdRGPskYO95HqSX6cstfceE9rZml12UmR2p R8JMK8K0y2FAnwfdDe6qCJS+xGCdCU9U9wcKfZ0OOhv76DqPNNAOi8oARQioHTQiSK WjdgKxo7Ch8pg== From: Jakub Kicinski To: davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, michael.chan@broadcom.com, Jakub Kicinski Subject: [PATCH net-next 0/3] eth: bnxt: handle invalid Tx completions more gracefully Date: Mon, 10 Jul 2023 13:56:08 -0700 Message-ID: <20230710205611.1198878-1-kuba@kernel.org> X-Mailer: git-send-email 2.41.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit bnxt trusts the events generated by the device which may lead to kernel crashes. These are extremely rare but they do happen. For a while I thought crashing may be intentional, because device reporting invalid completions should never happen, and having a core dump could be useful if it does. But in practice I haven't found any clues in the core dumps, and panic_on_warn exists. Series was tested by forcing the recovery path manually. Because of how rare the real crashes are I can't confirm it works for the actual device errors until it's been widely deployed. Jakub Kicinski (3): eth: bnxt: move and rename reset helpers eth: bnxt: take the bit to set as argument of bnxt_queue_sp_work() eth: bnxt: handle invalid Tx completions more gracefully drivers/net/ethernet/broadcom/bnxt/bnxt.c | 143 +++++++++++----------- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 + 2 files changed, 74 insertions(+), 70 deletions(-) -- 2.41.0