From: Jakub Kicinski <kuba@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: Florian Kauer <florian.kauer@linutronix.de>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
netdev@vger.kernel.org, kurt@linutronix.de,
vinicius.gomes@intel.com, muhammad.husaini.zulkifli@intel.com,
tee.min.tan@linux.intel.com, aravindhan.gunasekaran@intel.com,
sasha.neftin@intel.com, Naama Meir <naamax.meir@linux.intel.com>
Subject: Re: [PATCH net 5/6] igc: Fix launchtime before start of cycle
Date: Tue, 11 Jul 2023 17:54:54 -0700 [thread overview]
Message-ID: <20230711175454.040822b1@kernel.org> (raw)
In-Reply-To: <20230711101233.GM41919@unreal>
On Tue, 11 Jul 2023 13:12:33 +0300 Leon Romanovsky wrote:
> > If I understand correctly, ktime_sub_ns(txtime, baset_est) will only return
> > something larger than s32 max if cycle_time is larger than s32 max and if that
> > is the case everything will be broken anyway since the corresponding hardware
> > register only holds 30 bits.
>
> I suggest you to use proper variable types, what about the following
> snippet?
>
> ktime_t launchtime;
>
> launchtime = ktime_sub_ns(txtime, baset_est);
> WARN_ON(upper_32_bits(launchtime));
> div_s64_rem(launchtime, cycle_time, &launchtime);
>
> return cpu_to_le32(lower_32_bits(launchtime));
That needs to be coupled with some control path checks on cycle_time?
Seems like a separate fix TBH.
next prev parent reply other threads:[~2023-07-12 0:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 16:34 [PATCH net 0/6][pull request] igc: Fix corner cases for TSN offload Tony Nguyen
2023-07-10 16:34 ` [PATCH net 1/6] igc: Rename qbv_enable to taprio_offload_enable Tony Nguyen
2023-07-11 7:01 ` Leon Romanovsky
2023-07-11 7:18 ` Florian Kauer
2023-07-11 7:32 ` Leon Romanovsky
2023-07-11 7:51 ` Florian Kauer
2023-07-12 0:58 ` Jakub Kicinski
2023-07-12 6:53 ` Florian Kauer
2023-07-12 20:37 ` Tony Nguyen
2023-07-10 16:34 ` [PATCH net 2/6] igc: Do not enable taprio offload for invalid arguments Tony Nguyen
2023-07-11 7:03 ` Leon Romanovsky
2023-07-10 16:35 ` [PATCH net 3/6] igc: Handle already enabled taprio offload for basetime 0 Tony Nguyen
2023-07-11 7:03 ` Leon Romanovsky
2023-07-10 16:35 ` [PATCH net 4/6] igc: No strict mode in pure launchtime/CBS offload Tony Nguyen
2023-07-11 7:09 ` Leon Romanovsky
2023-07-10 16:35 ` [PATCH net 5/6] igc: Fix launchtime before start of cycle Tony Nguyen
2023-07-11 7:09 ` Leon Romanovsky
2023-07-11 8:37 ` Florian Kauer
2023-07-11 10:12 ` Leon Romanovsky
2023-07-12 0:54 ` Jakub Kicinski [this message]
2023-07-12 6:11 ` Leon Romanovsky
2023-07-10 16:35 ` [PATCH net 6/6] igc: Fix inserting of empty frame for launchtime Tony Nguyen
2023-07-11 7:11 ` Leon Romanovsky
2023-07-12 9:10 ` [PATCH net 0/6][pull request] igc: Fix corner cases for TSN offload patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230711175454.040822b1@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=aravindhan.gunasekaran@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.kauer@linutronix.de \
--cc=kurt@linutronix.de \
--cc=leon@kernel.org \
--cc=muhammad.husaini.zulkifli@intel.com \
--cc=naamax.meir@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sasha.neftin@intel.com \
--cc=tee.min.tan@linux.intel.com \
--cc=vinicius.gomes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).