From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0633B362 for ; Wed, 12 Jul 2023 02:29:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 197E1C433C7; Wed, 12 Jul 2023 02:29:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689128984; bh=xG9e3he2guVchwzogX81WG2OjmLVudMKkd8lmisKZHM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dFZazsH3rTpa33QyrA3jWxvDVplYudACM5N4yl8iF9PjIelC2bkMfQoY/RCtdpipD OGTVEDnh/Wr218brznfs1lsGdv1HyzIR4aqiXix3GxRfwKk+BXLIB9aZG1Ty43xuoi miD1c5U1/VufztrrDwSF3aXl5awMQbTjdsuNkad1ASZQJJBmwh8SrrxN+6hOPnTeMp LNzhXRL2rzCfKGxyJ2NtEp9lwEEXKFjSK7/3Oiy49zdULf6zWk3P4nTKLvl26WAdrJ dgaPsgacE5SVl8gN/AfhSLhLIUWIeFs0vPjTNF8nx25J+X8B/8QI620i5T00m6npDC tkjpIKY3sVbAg== Date: Tue, 11 Jul 2023 19:29:43 -0700 From: Jakub Kicinski To: Yang Rong Cc: "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , "David S. Miller" , Eric Dumazet , Paolo Abeni , virtualization@lists.linux-foundation.org (open list:VIRTIO CORE AND NET DRIVERS), netdev@vger.kernel.org (open list:NETWORKING DRIVERS), linux-kernel@vger.kernel.org (open list), opensource.kernel@vivo.com, luhongfei@vivo.com Subject: Re: [PATCH] virtio_net: Use max() function for better coding conventions Message-ID: <20230711192943.7a541984@kernel.org> In-Reply-To: <20230710012508.2119-1-yangrong@vivo.com> References: <20230710012508.2119-1-yangrong@vivo.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 10 Jul 2023 09:20:51 +0800 Yang Rong wrote: > It is advisable to utilize the max() function in the virtio_net.c file, > as it conforms better to programming conventions. > > Signed-off-by: Yang Rong Unnecessary churn, please don't send max() conversions to networking. -- pw-bot: reject