From: Jakub Kicinski <kuba@kernel.org>
To: Ivan Babrou <ivan@cloudflare.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@cloudflare.com, Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
David Ahern <dsahern@kernel.org>
Subject: Re: [RFC PATCH net-next] tcp: add a tracepoint for tcp_listen_queue_drop
Date: Tue, 11 Jul 2023 19:36:12 -0700 [thread overview]
Message-ID: <20230711193612.22c9bc04@kernel.org> (raw)
In-Reply-To: <20230711043453.64095-1-ivan@cloudflare.com>
On Mon, 10 Jul 2023 21:34:52 -0700 Ivan Babrou wrote:
> There's already a way to count the overall numbers of queue overflows:
>
> $ sudo netstat -s | grep 'listen queue'
> 4 times the listen queue of a socket overflowed
>
> However, it's too coarse for monitoring and alerting when a user wants to
> track errors per socket and route alerts to people responsible for those
> sockets directly. For UDP there's udp_fail_queue_rcv_skb, which fills
> a similar need for UDP sockets. This patch adds a TCP equivalent.
Makes me want to revert your recent UDP tracepoint to be honest :(
We can play whack a mole like this. You said that kfree_skb fires
too often, why is that? Maybe it's an issue of someone using
kfree_skb() when they should be using consume_skb() ?
next prev parent reply other threads:[~2023-07-12 2:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 4:34 [RFC PATCH net-next] tcp: add a tracepoint for tcp_listen_queue_drop Ivan Babrou
2023-07-12 2:36 ` Jakub Kicinski [this message]
2023-07-12 16:42 ` Yan Zhai
2023-07-12 17:42 ` Jakub Kicinski
2023-07-13 2:43 ` Yan Zhai
2023-07-13 16:57 ` Jakub Kicinski
2023-07-13 23:17 ` Ivan Babrou
2023-07-14 3:14 ` Jakub Kicinski
2023-07-14 23:21 ` Ivan Babrou
2023-07-18 21:57 ` Jakub Kicinski
2023-07-18 22:11 ` Ivan Babrou
2023-07-14 15:09 ` David Ahern
2023-07-14 23:38 ` Ivan Babrou
2023-07-15 1:30 ` David Ahern
2023-07-18 22:10 ` Ivan Babrou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230711193612.22c9bc04@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=ivan@cloudflare.com \
--cc=kernel-team@cloudflare.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).