From: Jakub Kicinski <kuba@kernel.org>
To: Michael Chan <michael.chan@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com
Subject: Re: [PATCH net-next 3/3] eth: bnxt: handle invalid Tx completions more gracefully
Date: Tue, 11 Jul 2023 21:24:21 -0700 [thread overview]
Message-ID: <20230711212421.02a36ab3@kernel.org> (raw)
In-Reply-To: <CACKFLi=5U_vpBL9tF6wv9WR_ZvuQzQnW+ETKAwUV_eD6xXEgOQ@mail.gmail.com>
On Tue, 11 Jul 2023 21:11:02 -0700 Michael Chan wrote:
> These are per ring counters. During complete reset, we free the ring
> and allocate a new ring. So re-applying these counters to the new
> ring doesn't make sense because the new ring is not necessarily the
> same as the old one. So I think we'll need to have a total for each
> of these and we'll save the snapshot of the total before reset and
> restore the snapshot after reset. Does that make sense?
Not entirely sure what you mean by total. The counters are reported
in ethool -S per ring and (aggregated) in ip -s -s.
Are you saying that in ethtool -S in addition to per-ring counts
we'd report a "total" which is sum(current per ring) + saved?
If so - that makes sense, yup.
ip -s -s sort of follows so no need discussing.
You mention reset but the errors counters should survive close() /
open() cycles as well.
next prev parent reply other threads:[~2023-07-12 4:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 20:56 [PATCH net-next 0/3] eth: bnxt: handle invalid Tx completions more gracefully Jakub Kicinski
2023-07-10 20:56 ` [PATCH net-next 1/3] eth: bnxt: move and rename reset helpers Jakub Kicinski
2023-07-10 20:56 ` [PATCH net-next 2/3] eth: bnxt: take the bit to set as argument of bnxt_queue_sp_work() Jakub Kicinski
2023-07-10 20:56 ` [PATCH net-next 3/3] eth: bnxt: handle invalid Tx completions more gracefully Jakub Kicinski
2023-07-11 8:00 ` Michael Chan
2023-07-12 0:01 ` Michael Chan
2023-07-12 1:09 ` Jakub Kicinski
2023-07-12 4:11 ` Michael Chan
2023-07-12 4:24 ` Jakub Kicinski [this message]
2023-07-12 4:50 ` Michael Chan
2023-07-12 16:35 ` Jakub Kicinski
2023-07-11 10:10 ` Paolo Abeni
2023-07-12 1:19 ` Jakub Kicinski
2023-07-12 6:50 ` Paolo Abeni
2023-07-12 16:34 ` Jakub Kicinski
2023-07-12 20:31 ` Paolo Abeni
2023-07-12 20:50 ` Jakub Kicinski
2023-07-10 21:44 ` [PATCH net-next 0/3] " Michael Chan
2023-07-11 0:38 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230711212421.02a36ab3@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).