From: Jakub Kicinski <kuba@kernel.org>
To: Dinh Nguyen <dinguyen@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
joabreu@synopsys.com, pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowskii+dt@linaro.org, conor+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] net: dwmac_socfpga: use the standard "ahb" reset
Date: Wed, 12 Jul 2023 17:08:40 -0700 [thread overview]
Message-ID: <20230712170840.3d66da6a@kernel.org> (raw)
In-Reply-To: <20230710211313.567761-2-dinguyen@kernel.org>
On Mon, 10 Jul 2023 16:13:13 -0500 Dinh Nguyen wrote:
> - dwmac->stmmac_ocp_rst = devm_reset_control_get_optional(dev, "stmmaceth-ocp");
> - if (IS_ERR(dwmac->stmmac_ocp_rst)) {
> - ret = PTR_ERR(dwmac->stmmac_ocp_rst);
> - dev_err(dev, "error getting reset control of ocp %d\n", ret);
> - goto err_remove_config_dt;
> - }
> -
> - reset_control_deassert(dwmac->stmmac_ocp_rst);
Noob question, perhaps - what's the best practice for incompatible
device tree changes? Updating the in-tree definitions is good enough?
Seems like we could quite easily continue to support "stmmaceth-ocp"
but no point complicating the code if not required.
next prev parent reply other threads:[~2023-07-13 0:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 21:13 [PATCH 1/2] arm64: dts: socfpga: change the reset-name of "stmmaceth-ocp" to "ahb" Dinh Nguyen
2023-07-10 21:13 ` [PATCH 2/2] net: dwmac_socfpga: use the standard "ahb" reset Dinh Nguyen
2023-07-13 0:08 ` Jakub Kicinski [this message]
2023-07-13 8:24 ` Krzysztof Kozlowski
2023-07-13 12:39 ` Paolo Abeni
2023-07-13 16:51 ` Jakub Kicinski
2023-07-14 14:41 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230712170840.3d66da6a@kernel.org \
--to=kuba@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=krzysztof.kozlowskii+dt@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).