From: Jakub Kicinski <kuba@kernel.org>
To: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
chuck.lever@oracle.com
Subject: Re: [PATCH net-next 1/2 v2] tools: ynl-gen: fix enum index in _decode_enum(..)
Date: Thu, 13 Jul 2023 09:02:34 -0700 [thread overview]
Message-ID: <20230713090234.28b04145@kernel.org> (raw)
In-Reply-To: <20230713090550.132858-2-arkadiusz.kubalewski@intel.com>
On Thu, 13 Jul 2023 11:05:49 +0200 Arkadiusz Kubalewski wrote:
> - i = attr_spec.get('value-start', 0)
> if 'enum-as-flags' in attr_spec and attr_spec['enum-as-flags']:
> value = set()
> while raw:
> if raw & 1:
> - value.add(enum.entries_by_val[i].name)
> + value.add(enum.entries_by_val[raw & 1].name)
> raw >>= 1
> - i += 1
This doesn't make sense, as I suggested you need to keep i for this
loop. Move it to the inside of the if 'enum-as-fla... and init to 0.
i is tracking which bit number we are at as we consume / shift out
bits from raw.
Have you ever used ChatGPT? No shame, just curious.
--
pw-bot: cr
next prev parent reply other threads:[~2023-07-13 16:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 9:05 [PATCH net-next 0/2] tools: ynl-gen: fix parse multi-attr enum attribute Arkadiusz Kubalewski
2023-07-13 9:05 ` [PATCH net-next 1/2 v2] tools: ynl-gen: fix enum index in _decode_enum(..) Arkadiusz Kubalewski
2023-07-13 16:02 ` Jakub Kicinski [this message]
2023-07-18 16:30 ` Kubalewski, Arkadiusz
2023-07-13 9:05 ` [PATCH net-next 2/2 v2] tools: ynl-gen: fix parse multi-attr enum attribute Arkadiusz Kubalewski
2023-07-13 16:08 ` Jakub Kicinski
2023-07-18 16:56 ` Kubalewski, Arkadiusz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230713090234.28b04145@kernel.org \
--to=kuba@kernel.org \
--cc=arkadiusz.kubalewski@intel.com \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).