From: Rob Herring <robh@kernel.org>
To: Samin Guo <samin.guo@starfivetech.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
netdev@vger.kernel.org, Peter Geis <pgwipeout@gmail.com>,
Frank <Frank.Sae@motor-comm.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Conor Dooley <conor@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Yanhong Wang <yanhong.wang@starfivetech.com>
Subject: Re: [PATCH v4 1/2] dt-bindings: net: motorcomm: Add pad driver strength cfg
Date: Fri, 14 Jul 2023 20:47:11 -0600 [thread overview]
Message-ID: <20230715024711.GB872287-robh@kernel.org> (raw)
In-Reply-To: <20230714101406.17686-2-samin.guo@starfivetech.com>
On Fri, Jul 14, 2023 at 06:14:05PM +0800, Samin Guo wrote:
> The motorcomm phy (YT8531) supports the ability to adjust the drive
> strength of the rx_clk/rx_data.
>
> The YT8531 RGMII LDO voltage supports 1.8V/3.3V, and the
> LDO voltage can be configured with hardware pull-up resistors to match
> the SOC voltage (usually 1.8V). The software can read the registers
> 0xA001 obtain the current LDO voltage value.
>
> When we configure the drive strength, we need to read the current LDO
> voltage value to ensure that it is a legal value at that LDO voltage.
>
> Reviewed-by: Hal Feng <hal.feng@starfivetech.com>
> Signed-off-by: Samin Guo <samin.guo@starfivetech.com>
> ---
> .../bindings/net/motorcomm,yt8xxx.yaml | 46 +++++++++++++++++++
> 1 file changed, 46 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml b/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml
> index 157e3bbcaf6f..097bf143af35 100644
> --- a/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml
> +++ b/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml
> @@ -52,6 +52,52 @@ properties:
> for a timer.
> type: boolean
>
> + motorcomm,rx-clk-driver-strength:
> + $ref: /schemas/types.yaml#/definitions/uint32
As the units are uA, drop the type and add '-microamp' suffix.
'motorcomm,rx-clk-drv-microamp' is probably sufficient.
> + description: |
> + drive strength of rx_clk rgmii pad.
> + |----------------------------------|
> + | rx_clk ds map table |
> + |----------------------------------|
> + | DS(3b) | wol@1.8v | wol@3.3v |
> + |________|_________________________|
> + | | current(uA)| current(uA)|
> + | 000 | 1200 | 3070 |
> + | 001 | 2100 | 4080 |
> + | 010 | 2700 | 4370 |
> + | 011 | 2910 | 4680 |
> + | 100 | 3110 | 5020 |
> + | 101 | 3600 | 5450 |
> + | 110 | 3970 | 5740 |
> + | 111 | 4350 | 6140 |
> + |--------|------------|------------|
> + enum: [ 1200, 2100, 2700, 2910, 3070, 3110, 3600, 3970,
> + 4080, 4350, 4370, 4680, 5020, 5450, 5740, 6140 ]
> + default: 2910
> +
> + motorcomm,rx-data-driver-strength:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + drive strength of rx_data/rx_ctl rgmii pad.
> + |----------------------------------|
> + | rx_data ds map table |
> + |----------------------------------|
> + | DS(3b) | wol@1.8v | wol@3.3v |
> + |________|_________________________|
> + | | current(uA)| current(uA)|
> + | 000 | 1200 | 3070 |
> + | 001 | 2100 | 4080 |
> + | 010 | 2700 | 4370 |
> + | 011 | 2910 | 4680 |
> + | 100 | 3110 | 5020 |
> + | 101 | 3600 | 5450 |
> + | 110 | 3970 | 5740 |
> + | 111 | 4350 | 6140 |
> + |--------|------------|------------|
> + enum: [ 1200, 2100, 2700, 2910, 3070, 3110, 3600, 3970,
> + 4080, 4350, 4370, 4680, 5020, 5450, 5740, 6140 ]
> + default: 2910
> +
> motorcomm,tx-clk-adj-enabled:
> description: |
> This configuration is mainly to adapt to VF2 with JH7110 SoC.
> --
> 2.17.1
>
next prev parent reply other threads:[~2023-07-15 2:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 10:14 [PATCH v4 0/2] Add motorcomm phy pad-driver-strength-cfg support Samin Guo
2023-07-14 10:14 ` [PATCH v4 1/2] dt-bindings: net: motorcomm: Add pad driver strength cfg Samin Guo
2023-07-14 18:54 ` Andrew Lunn
2023-07-17 8:28 ` Guo Samin
2023-07-15 2:47 ` Rob Herring [this message]
2023-07-17 8:35 ` Guo Samin
2023-07-14 10:14 ` [PATCH v4 2/2] net: phy: motorcomm: Add pad drive strength cfg support Samin Guo
2023-07-14 18:49 ` Andrew Lunn
2023-07-17 8:40 ` Guo Samin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230715024711.GB872287-robh@kernel.org \
--to=robh@kernel.org \
--cc=Frank.Sae@motor-comm.com \
--cc=andrew@lunn.ch \
--cc=conor@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pgwipeout@gmail.com \
--cc=samin.guo@starfivetech.com \
--cc=yanhong.wang@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).