From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F0BC39D for ; Sat, 15 Jul 2023 02:47:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B65F7C433C8; Sat, 15 Jul 2023 02:47:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689389234; bh=cSL9tSXE1IYkMTAzMwc2gHb95tSzr+oNTr7zMsZ9vDE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CqCnKzlOw+c5jOXlp0PuUA0EL9dIzvtBPSgh8F0gOLHJ/jgfYWhBDXBs9q3iQIqdJ kPmdeohANF8QOE26tIyLiEkzmqXEMQ7Xgh4Sb4F9RzhElqnbv/DXRg7Xglt8+8F5Tx AmI3tC8lfFdDxA3Ji80o83oRFLu3/YA1tpIEmnqzmWVGM+ge7225yZRy9gkjW94U0w Ms0+LAxH6W0GtpEk360OpAUPHpNDjbBYmouNOpiKDoLnfz/1D+lm8W9BfVCdjokevN 6JAeg/62rVzsY/jP2tTyDd94I9lAIuTPzoyHUDt+/5jLKK+qqURCrVk3k3M2QMyl3S viiIK1nEz4k+w== Received: (nullmailer pid 875753 invoked by uid 1000); Sat, 15 Jul 2023 02:47:11 -0000 Date: Fri, 14 Jul 2023 20:47:11 -0600 From: Rob Herring To: Samin Guo Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, Peter Geis , Frank , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Conor Dooley , Krzysztof Kozlowski , Andrew Lunn , Heiner Kallweit , Russell King , Yanhong Wang Subject: Re: [PATCH v4 1/2] dt-bindings: net: motorcomm: Add pad driver strength cfg Message-ID: <20230715024711.GB872287-robh@kernel.org> References: <20230714101406.17686-1-samin.guo@starfivetech.com> <20230714101406.17686-2-samin.guo@starfivetech.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230714101406.17686-2-samin.guo@starfivetech.com> On Fri, Jul 14, 2023 at 06:14:05PM +0800, Samin Guo wrote: > The motorcomm phy (YT8531) supports the ability to adjust the drive > strength of the rx_clk/rx_data. > > The YT8531 RGMII LDO voltage supports 1.8V/3.3V, and the > LDO voltage can be configured with hardware pull-up resistors to match > the SOC voltage (usually 1.8V). The software can read the registers > 0xA001 obtain the current LDO voltage value. > > When we configure the drive strength, we need to read the current LDO > voltage value to ensure that it is a legal value at that LDO voltage. > > Reviewed-by: Hal Feng > Signed-off-by: Samin Guo > --- > .../bindings/net/motorcomm,yt8xxx.yaml | 46 +++++++++++++++++++ > 1 file changed, 46 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml b/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml > index 157e3bbcaf6f..097bf143af35 100644 > --- a/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml > +++ b/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml > @@ -52,6 +52,52 @@ properties: > for a timer. > type: boolean > > + motorcomm,rx-clk-driver-strength: > + $ref: /schemas/types.yaml#/definitions/uint32 As the units are uA, drop the type and add '-microamp' suffix. 'motorcomm,rx-clk-drv-microamp' is probably sufficient. > + description: | > + drive strength of rx_clk rgmii pad. > + |----------------------------------| > + | rx_clk ds map table | > + |----------------------------------| > + | DS(3b) | wol@1.8v | wol@3.3v | > + |________|_________________________| > + | | current(uA)| current(uA)| > + | 000 | 1200 | 3070 | > + | 001 | 2100 | 4080 | > + | 010 | 2700 | 4370 | > + | 011 | 2910 | 4680 | > + | 100 | 3110 | 5020 | > + | 101 | 3600 | 5450 | > + | 110 | 3970 | 5740 | > + | 111 | 4350 | 6140 | > + |--------|------------|------------| > + enum: [ 1200, 2100, 2700, 2910, 3070, 3110, 3600, 3970, > + 4080, 4350, 4370, 4680, 5020, 5450, 5740, 6140 ] > + default: 2910 > + > + motorcomm,rx-data-driver-strength: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + drive strength of rx_data/rx_ctl rgmii pad. > + |----------------------------------| > + | rx_data ds map table | > + |----------------------------------| > + | DS(3b) | wol@1.8v | wol@3.3v | > + |________|_________________________| > + | | current(uA)| current(uA)| > + | 000 | 1200 | 3070 | > + | 001 | 2100 | 4080 | > + | 010 | 2700 | 4370 | > + | 011 | 2910 | 4680 | > + | 100 | 3110 | 5020 | > + | 101 | 3600 | 5450 | > + | 110 | 3970 | 5740 | > + | 111 | 4350 | 6140 | > + |--------|------------|------------| > + enum: [ 1200, 2100, 2700, 2910, 3070, 3110, 3600, 3970, > + 4080, 4350, 4370, 4680, 5020, 5450, 5740, 6140 ] > + default: 2910 > + > motorcomm,tx-clk-adj-enabled: > description: | > This configuration is mainly to adapt to VF2 with JH7110 SoC. > -- > 2.17.1 >