From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FC541854 for ; Sun, 16 Jul 2023 10:39:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D27BC433C7; Sun, 16 Jul 2023 10:39:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689503991; bh=9jtUWxQYiBFV2MFeXaOw/zVh4iC4TPR3WZN1TK18XQs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CCnbgt0hkEa/c+Z1QnNsYdbSdtCWHpkFEV1JZgN7hrBmmdf2JddlKJXz1WiDLF+gG vYksuX9e5wxmLsRcpcK5VCGaj4KodJEipBGuCjmL8wC9xKf7jdXH1eMjsEqm39IVxC sNlfTUyiXqdbz0MNcLVzREOoIQXtrVXCUbAdpOheZODtKmNKtlr3kmyuvGgm8qa3HE oKIWsQg47Fi1rZ7J1/Kt7htP6UyYs4Z10cN1UyXpVju5+vCLhE0Llr6+J4vMz+oQzE et/SJyvsLm2YAfbBeSwlMGNv4elPX/kml/a7QSAI2PzddO0aHaLyz3xfDMMoAgX7ar FkHSjDAY7viUw== Date: Sun, 16 Jul 2023 13:39:47 +0300 From: Leon Romanovsky To: Jakub Kicinski Cc: Saeed Mahameed , Jianbo Liu , Eric Dumazet , Mark Bloch , netdev@vger.kernel.org, Paolo Abeni , "David S . Miller" , Simon Horman Subject: Re: [PATCH net-next 09/12] net/mlx5: Compare with old_dest param to modify rule destination Message-ID: <20230716103947.GA27947@unreal> References: <20230713063345.GG41919@unreal> <20230713100401.5fe0fa77@kernel.org> <20230713174317.GH41919@unreal> <20230713110556.682d21ba@kernel.org> <20230713185833.GI41919@unreal> <20230713201727.6dfe7549@kernel.org> <20230714184013.GJ41919@unreal> <20230714121633.18d19c4c@kernel.org> <20230714203258.GL41919@unreal> <20230714203032.7f1bf5f7@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230714203032.7f1bf5f7@kernel.org> On Fri, Jul 14, 2023 at 08:30:32PM -0700, Jakub Kicinski wrote: > On Fri, 14 Jul 2023 23:32:58 +0300 Leon Romanovsky wrote: > > On Fri, Jul 14, 2023 at 12:16:33PM -0700, Jakub Kicinski wrote: > > > On Fri, 14 Jul 2023 21:40:13 +0300 Leon Romanovsky wrote: > > > > It depends on configuration order, if user configures TC first, it will > > > > be a), if he/she configures IPsec first, it will be b). > > > > > > > > I just think that option b) is really matters. > > > > > > And only b) matches what happens in the kernel with policy based IPsec, > > > right? > > > > Can you please clarify what do you mean "policy based IPsec"? > > I mean without a separate xfrm netdev on which you can install TC > rules of its own. I call it software IPsec. > > > > IIUC what you're saying - > > > the result depending on order of configuration may be a major source > > > of surprises / hard to debug problems for the user. > > > > When I reviewed patches, I came exactly to an opposite conclusion :) > > > > My rationale was that users who configure IPsec and TC are advanced > > users who knows their data flow and if they find a) option valuable, > > they can do it. > > > > For example, a) allows to limit amount of data sent to IPsec engine. > > > > I believe both a) and b) should be supported. > > What does it take to switch between the modes? > Even if we want both modes we should have an explicit switch, I reckon. > Or at least a way to read back what mode we ended up in. I had several internal discussions about how TC and IPsec should work together, and will need some time to think about proper implementation. For now I'll add patch which makes TC and IPsec mutually exclusive. Thanks >